Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3] Behavior>>addCategory:environmentId: needs to have a Rowan hook ... #908

Open
dalehenrich opened this issue Jan 9, 2024 · 0 comments
Open

[v3] Behavior>>addCategory:environmentId: needs to have a Rowan hook ... #908

dalehenrich opened this issue Jan 9, 2024 · 0 comments
Assignees
@dalehenrich
Labels
next up top of todo list

Comments

@dalehenrich
Copy link
Member

Behavior>>addCategory:environmentId: is the standard method for adding method categories to a class and Rowan needs to have a hook (_rwAddCategory:environmentId:) to be able to enforce package conventions when the class is packaged ... similar to #_rwMoveMethod:toCategory: and _rwCompileMethodForConditionalPackaging:symbolList:category:environmentId:ifUnpackagedDo: ... required as part of the fix for #875 ... since part of the fix for GemTalk/Jadeite#956 was to use addCategory: which currently bypasses Rowan altogether ...
@dalehenrich dalehenrich added the next up top of todo list label Jan 9, 2024
@dalehenrich dalehenrich self-assigned this Jan 9, 2024
@dalehenrich dalehenrich changed the title Behavior>>addCategory:environmentId: needs to have a Rowan hook ... [v3] Behavior>>addCategory:environmentId: needs to have a Rowan hook ... Jan 9, 2024
@dalehenrich dalehenrich mentioned this issue Jan 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dalehenrich dalehenrich

Labels
next up top of todo list
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dalehenrich