We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-dom
I would suggest to make react-dom an optional peerDependency, since pure react-native projects don't use react-dom at all.
peerDependency
react-native
The current forced peerDependency causes projects with no react-dom in their dependencies to cause an error with recent npm versions.
dependencies
npm
Add a peerDependencyMeta attribute inside package.json and declare react-dom as optional:
package.json
... "peerDependencyMeta": { "react-dom": { "optional": true } }, ...
The text was updated successfully, but these errors were encountered:
Hi @proohit, Thanks for reporting. We will do that, If you want to be a contributor, please do these changes and I will approve your PR. 😄
Sorry, something went wrong.
Sure thing!
Successfully merging a pull request may close this issue.
Description
I would suggest to make
react-dom
an optionalpeerDependency
, since purereact-native
projects don't usereact-dom
at all.Problem Statement
The current forced
peerDependency
causes projects with noreact-dom
in theirdependencies
to cause an error with recentnpm
versions.Proposed Solution or API
Add a peerDependencyMeta attribute inside
package.json
and declarereact-dom
as optional:The text was updated successfully, but these errors were encountered: