Rename relations #45
Merged
Rename relations #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the beginning of a series of commits that will try to unify the naming conventions of the Fact Generator and Datalog code. It's important to undertake this while the git history of the project is relatively short, so as to not hide valuable history by doing it later. At the same time, this set of changes will endeavor to make consistent, reasonable trade-offs between identifier clarity and brevity, and document these choices.
langston-barrett
force-pushed
the
lb/rename
branch
from
dd11725
to
68b067c
Compare
langston-barrett
force-pushed
the
lb/rename
branch
from
e3ecd07
to
45c4f8a
Compare
langston-barrett
force-pushed
the
lb/rename
branch
from
45c4f8a
to
e119c57
Compare
Used this script to rename files in datalog/schema:
import os
for f in os.listdir("."):
if "instruction" in f:
os.rename(f, f.replace("instruction", "instr"))
langston-barrett
force-pushed
the
lb/rename
branch
from
4602f5b
to
077eb7b
Compare
Gives an explicit goal to how relation names should be derived from group + attribute names.
Begin systematizing the names of attributes of instructions. This commit endeavors not to rename anything that appears in the fact generator nor Datalog, but merely to capture the existing system(s) of instruction attribute names. This will make it more obvious which ones lie outside these conventions, and make it easier to change them. This commit ends at `trunc`, further commits will do the rest.
langston-barrett
force-pushed
the
lb/rename
branch
from
4bb4b19
to
b1cfca2
Compare
Finish the work started in the previous commit.
langston-barrett
force-pushed
the
lb/rename
branch
from
b1cfca2
to
961897e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #42, #39.