Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stuttering when interacting with a music player, "Unhandled promise rejection" in journalctl #1605

Closed
back-lacking opened this issue Apr 15, 2023 · 17 comments · Fixed by #1609
Labels
bug An issue that is confirmed as a bug help wanted An issue that needs contributors

Comments

@back-lacking
Copy link

back-lacking commented Apr 15, 2023

Describe the bug

when interacting with music in a music player (in my case, strawberry music player), eg. playing/pausing and skipping to the next song, there would be a slight stutter.
https://pastebin.com/m2agA2Sk journalctl log

Steps to reproduce

  1. open music player of choice
  2. play music
  3. pause/resume, skip a song or go back to previous track.
  4. observe if there is a stutter.

Expected behavior

the system doesnt stutter when playing/pausing, skipping songs, etc in a music player.

GSConnect version

54

Installed from

GNOME Extensions website

GNOME Shell version

43.4

Linux distribution/release

Fedora 37

Paired device(s)

LG G7 ThinQ

KDE Connect app version

1.24.0

Plugin(s)

No response

Support log

https://pastebin.com/HjgDAWgY because github cant send the issue with the raw text

Screenshots

No response

Notes

If more info is needed, tell me.

@github-actions github-actions bot added the triage An issue that needs confirmation and labeling label Apr 15, 2023
@back-lacking
Copy link
Author

@andyholmes andyholmes added bug An issue that is confirmed as a bug help wanted An issue that needs contributors and removed triage An issue that needs confirmation and labeling labels Apr 17, 2023
@andyholmes
Copy link
Collaborator

Thanks for the report and logs!

Looks like there is indeed an uncaught Promise in the lan plugin. I'm not sure if that's the cause of the stutter, but it would be good place to start.

@ferdnyc
Copy link
Member

ferdnyc commented Apr 23, 2023

@back-lacking Unfortunately, that pastebin seems to have expired, so the log can no longer be accessed.

Please attach the log directly to this report (you can insert files directly into a comment using the GitHub web interface — .txt and .log files are accepted directly, any other format should be stored inside a .zip archive) so that we can use them to track down the problem.

@ferdnyc ferdnyc added the needs info An issue that needs more information label Apr 23, 2023
@back-lacking
Copy link
Author

back-lacking commented Apr 23, 2023

@back-lacking Unfortunately, that pastebin seems to have expired, so the log can no longer be accessed.

Please attach the log directly to this report (you can insert files directly into a comment using the GitHub web interface — .txt and .log files are accepted directly, any other format should be stored inside a .zip archive) so that we can use them to track down the problem.

gsconnect.6ZBE31.txt
gsconnect.N68021.txt
here are the 2 logs i gathered for this issue

journalctl log:
journalctl.txt

andyholmes added a commit that referenced this issue Apr 24, 2023
The `lan` backend wasn't really dealing with concurrency of negotiating
auxiliary streams (i.e. transfers) at all.

Make a few minor modifications to correct a number of race conditions
and lost warnings.

closes #1605
andyholmes added a commit that referenced this issue Apr 24, 2023
The `lan` backend wasn't really dealing with concurrency of negotiating
auxiliary streams (i.e. transfers) at all.

Make a few minor modifications to correct a number of race conditions
and lost warnings.

closes #1605
@andyholmes
Copy link
Collaborator

You can give the test build from #1609 a shot if you want. I'm not sure if it will solve the stuttering though.

@back-lacking
Copy link
Author

You can give the test build from #1609 a shot if you want. I'm not sure if it will solve the stuttering though.

just installed it using the install from zip instructions and now its "outdated" in the installed extensions
image
i remember i did a fix for a different extension which required me to chage like a json file and add my gnome version to it. does this need to be applied here?

@andyholmes
Copy link
Collaborator

andyholmes commented Apr 24, 2023

Yeah, GSConnect has moved to GNOME 44, so you'll have to add "43" to your metadata.json. That's in /.local/share/gnome-shell/extensions/[email protected].

@back-lacking
Copy link
Author

Yeah, GSConnect has moved to GNOME 44, so you'll have to add "43" to your metadata.json. That's in /.local/share/gnome-shell/extensions/[email protected].

trying to access that path returns an error, as that dir doesnt exist on my system. i remember i did it for an extension but forgot which one. also forgot where fedora stores the extension

@andyholmes
Copy link
Collaborator

Sorry, there should be a ~ at the beginning, so ~/.local/share/gnome-shell/extensions/[email protected].

@back-lacking
Copy link
Author

back-lacking commented Apr 24, 2023

Sorry, there should be a ~ at the beginning, so ~/.local/share/gnome-shell/extensions/[email protected].

so i did that edit, relogged into my user, and now the extension is just gone. doesnt show up in extension list or the gnome extensions website.
image
what my json looks like atm

@andyholmes
Copy link
Collaborator

It should look more like "shell-version": ["43, "44"],.

@ferdnyc
Copy link
Member

ferdnyc commented Apr 25, 2023

Unfortunately I don't think that will work, see #1611. Last time I had to get a test build to a GNOME 43 user, I built one locally off the v54 tag and uploaded it as an attachment to the issue.

@ferdnyc ferdnyc removed the needs info An issue that needs more information label Apr 25, 2023
@ferdnyc
Copy link
Member

ferdnyc commented Apr 25, 2023

Make that #1612.

@back-lacking
Copy link
Author

back-lacking commented Apr 25, 2023

It should look more like "shell-version": ["43, "44"],.

unable to enable the extension, its just red and i cant turn it on.
image

@andyholmes
Copy link
Collaborator

andyholmes commented Apr 25, 2023

If you copied that exactly, there was a typo in there. You'll want to add that missing quotation. Here's a ZIP:

[email protected]

Frank's probably right, so here's a ZIP that might work built off the last GNOME 43 commit I could find:

[email protected]

@back-lacking
Copy link
Author

back-lacking commented Apr 25, 2023

If you copied that exactly, there was a typo in there. You'll want to add that missing quotation. Here's a ZIP:

[email protected]

Frank's probably right, so here's a ZIP that might work built off the last GNOME 43 commit I could find:

[email protected]

just installed it, here is a fresh log.
gsconnect.P15231.txt

here is also a video showing it in action, i dont think there is a stutter now.
2023-04-25 18-11-51.zip

@andyholmes
Copy link
Collaborator

Well the error gets caught now, I bet that's the cause of a lot of uncaught promise rejections so might as well merge it. Thanks for testing!

Looks like the old packet queue on the device-side problem.

andyholmes added a commit that referenced this issue Apr 25, 2023
The `lan` backend wasn't really dealing with concurrency of negotiating
auxiliary streams (i.e. transfers) at all.

Make a few minor modifications to correct a number of race conditions
and lost warnings.

closes #1605
ferdnyc pushed a commit to ferdnyc/gnome-shell-extension-gsconnect that referenced this issue Apr 29, 2023
The `lan` backend wasn't really dealing with concurrency of negotiating
auxiliary streams (i.e. transfers) at all.

Make a few minor modifications to correct a number of race conditions
and lost warnings.

closes GSConnect#1605
ferdnyc pushed a commit that referenced this issue May 1, 2023
The `lan` backend wasn't really dealing with concurrency of negotiating
auxiliary streams (i.e. transfers) at all.

Make a few minor modifications to correct a number of race conditions
and lost warnings.

closes #1605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that is confirmed as a bug help wanted An issue that needs contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants