Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new fuels-npm-packs which supports devnet #1298

Closed
LuizAsFight opened this issue May 16, 2024 · 1 comment · Fixed by #1290
Closed

Use new fuels-npm-packs which supports devnet #1298

LuizAsFight opened this issue May 16, 2024 · 1 comment · Fixed by #1290
Assignees
@arthurgeron
Labels
e-testnet-launch https://github.com/FuelLabs/edge/issues/140 p0 For yesterday. critical bugs / big priorities

Comments

@LuizAsFight
Copy link
Contributor

LuizAsFight commented May 16, 2024 •
edited

after doing it, make sure that:

  • e2e tests and e2e-contract-tests are running smooth both on CI and local
  • e2e-contract-tests UI, all contract calls should be working fine locally
@LuizAsFight LuizAsFight mentioned this issue May 16, 2024
Merged
@LuizAsFight LuizAsFight added the p0 For yesterday. critical bugs / big priorities label May 16, 2024
@LuizAsFight
Copy link
Contributor Author

Closed in #1317

arthurgeron added a commit that referenced this issue May 28, 2024
@arthurgeron @LuizAsFight
@fuel-service-user @github-actions
fix: flaky e2e tests (#1290)
57f87f8 
Closes #1298 
Closes #1262 
- Re-enabled E2E contract tests
- Fixed biome trying to validate files generated by playwright test runs
- Fixed Playwright tests starting up before CRX files are available, now
runs `build` beforehand.
- Fixed CRX dev server reloading during playwright tests, causing
instabilities
- Fixed NODE_ENV being set to default (production) on local E2E tests,
leading to the wrong version (i.e. production) being installed
- Fixed bug where only the first test file in a suite run would use the
local CRX build, it'd then download and use a production build of the
Wallet for the rest

---------

Co-authored-by: Luiz Gomes - LuizAsFight.eth <[email protected]>
Co-authored-by: fuel-service-user <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@LuizAsFight LuizAsFight added the e-testnet-launch https://github.com/FuelLabs/edge/issues/140 label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthurgeron arthurgeron

Labels
e-testnet-launch https://github.com/FuelLabs/edge/issues/140 p0 For yesterday. critical bugs / big priorities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: flaky e2e tests FuelLabs/fuels-wallet
2 participants
@arthurgeron @LuizAsFight