Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset showing incorrectly in "DAPP Approve Transaction" screen #1297

Closed
LuizAsFight opened this issue May 14, 2024 · 0 comments · Fixed by #1317
Closed

Asset showing incorrectly in "DAPP Approve Transaction" screen #1297

LuizAsFight opened this issue May 14, 2024 · 0 comments · Fixed by #1317
Assignees
@arthurgeron
Labels
e-testnet-launch https://github.com/FuelLabs/edge/issues/140 p0 For yesterday. critical bugs / big priorities

Comments

@LuizAsFight
Copy link
Contributor

LuizAsFight commented May 14, 2024 •
edited

on calling a contract to transfer ETH, the DAPP approve screen is showing "unknown" asset. It should show ETH

1- Fix it to use correct baseAssetId from provider
2- Add in e2e-contracts-tests (every screen) to check if its showing the correct asset name

Image

also in the case below, the bridge withdraws eth from fuel, and the wallet shows "0x0000..." asset, while the correct one is not this ID. The withdraw works, which makes me think it's only a visual bug in wallet side (or sdk when processing "operations")

Image
@LuizAsFight LuizAsFight added the p1 label May 16, 2024
@LuizAsFight LuizAsFight added p0 For yesterday. critical bugs / big priorities and removed p1 labels May 27, 2024
@arthurgeron arthurgeron mentioned this issue May 28, 2024
Merged
arthurgeron added a commit that referenced this issue May 28, 2024
@arthurgeron
fix: wrong Asset Id and name on transaction approval screen (#1317)
f1dab20 
Fixes #1297 
- Fixes bug where wrong Asset Id is shown for other tokens (e.g. ETH)
- Updated Fuels package to tag pr-2395
- Updated NPM Packs dependencies packages (e.g. @fuels/react,
@fuels/ts-config) to new minor 0.20.0

<img width="347" alt="image"
src="https://github.com/FuelLabs/fuels-wallet/assets/3487334/ac96f0c7-be05-4bc3-9233-133ac3dc99f4">
@LuizAsFight LuizAsFight added the e-testnet-launch https://github.com/FuelLabs/edge/issues/140 label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthurgeron arthurgeron

Labels
e-testnet-launch https://github.com/FuelLabs/edge/issues/140 p0 For yesterday. critical bugs / big priorities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: wrong Asset Id and name on transaction approval screen FuelLabs/fuels-wallet
2 participants
@arthurgeron @LuizAsFight