Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base Asset SRC-20 Contract #172

Merged
merged 10 commits into from
May 23, 2024
Merged

Base Asset SRC-20 Contract #172

merged 10 commits into from
May 23, 2024

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Apr 23, 2024 •
edited

Description

Adds the SRC-20 implementation contract for the Fuel Network's Base Asset, Ether.

Uses fuel-core v0.26.0 and forc v0.56.1

Closes

Closes #160

@bitzoic bitzoic added the enhancement New feature or request label Apr 23, 2024
@bitzoic bitzoic self-assigned this Apr 23, 2024
@bitzoic bitzoic linked an issue Apr 23, 2024 that may be closed by this pull request
Base Asset Contract #160
Closed
dmihal
dmihal previously approved these changes May 1, 2024
View reviewed changes
@bitzoic
Copy link
Member Author

bitzoic commented May 9, 2024

Dependent on #180

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited

This PR is published in NPM with version 0.6.0-pr-172-3

@bitzoic bitzoic marked this pull request as ready for review May 21, 2024 03:00
@bitzoic bitzoic requested a review from dmihal May 22, 2024 09:02
@luizstacio luizstacio requested a review from DefiCake May 22, 2024 13:21
DefiCake
DefiCake approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@DefiCake DefiCake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

DefiCake
DefiCake reviewed May 22, 2024
View reviewed changes
Copy link
Member

@DefiCake DefiCake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only add to double check that the binary has been generated with --release.

@bitzoic
Copy link
Member Author

bitzoic commented May 22, 2024

I would only add to double check that the binary has been generated with --release.

Release is used in the const for the bytecode path

fuel-bridge/packages/base-asset/tests/harness.rs

Line 12 in 3aaaaf4

const BASE_ASSET_CONTRACT_BYTECODE_PATH: &str = "out/release/base-asset-contract.bin";

@DefiCake
Copy link
Member

I just checked manually, we are good to go 👍🏻

@bitzoic bitzoic merged commit 85a54c9 into main May 23, 2024
7 checks passed
@bitzoic bitzoic deleted the bitzoic-160 branch May 23, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DefiCake DefiCake DefiCake approved these changes

@luizstacio luizstacio luizstacio approved these changes

@dmihal dmihal Awaiting requested review from dmihal

Assignees

@bitzoic bitzoic

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base Asset Contract
4 participants
@bitzoic @DefiCake @dmihal @luizstacio