Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dired-subtree buffer does not refresh after executing an action #176

Open
mtreca opened this issue Jan 30, 2021 · 3 comments · May be fixed by #190
Open

dired-subtree buffer does not refresh after executing an action #176

mtreca opened this issue Jan 30, 2021 · 3 comments · May be fixed by #190

Comments

@mtreca
Copy link

mtreca commented Jan 30, 2021

The title pretty much says it all. When executing an action on a subtree in a dired buffer (such as moving or deleting files), these files are still displayed because the buffer is not refreshed. This does not happen on non-subtreed dired buffers. I tried to investigate things a little and I would guess this would have something to do with the dired-after-readin-hook not activating.

@Fuco1
Copy link
Owner

Fuco1 commented Feb 4, 2021

I think this is actually configurable in regular dired. My suspicion is that we do not respect this setting somewhere, as you say.

If you hit g, does it reload properly? If so that might be a simple solution. We could also try to detect where the operation happened (ie in a subtree) but that seems very unlikely to work reliably.

@mtreca
Copy link
Author

mtreca commented Feb 4, 2021

@Fuco1 Thanks for the reply! Yes regular dired refreshes buffers by default.

Hitting g does reload the buffer properly, so the fix should be simple indeed (maybe adding a missing hook?)

@mtreca
Copy link
Author

mtreca commented Feb 8, 2021

Additionally, I am noticing that refreshing a dired-subtree buffer using g overrides dired-omit-mode and shows normally hidden files (they are not shown when the subtree buffer is opened for the first time). I am guessing these two issues are probably linked.

ilohmar added a commit to ilohmar/dired-hacks that referenced this issue Mar 2, 2022
Correct `auto-revert-mode' behavior is based on the
`buffer-stale-function' `dired-buffer-stale-p'.  Remember the subtrees'
modification times and override `dired-buffer-stale-p' to take them into
account.

Fixes Fuco1#176.
@ilohmar ilohmar linked a pull request Mar 2, 2022 that will close this issue
@Fuco1 Fuco1 added this to Triage Mar 18, 2024
@github-project-automation github-project-automation bot moved this to To triage in Triage Mar 18, 2024
@Fuco1 Fuco1 moved this from To triage to Backlog in Triage Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants