github updated post doesnt get marked as unread #6443

rezad1393 · 2024-05-09T01:21:38Z

rezad1393
May 9, 2024

To Reproduce
Steps to reproduce the behavior:
add this feed
https://github.com/0x90d/videoduplicatefinder/releases.atom
it has a daily (but it is not daily) build with the same link repeated , like this https://github.com/0x90d/videoduplicatefinder/releases/tag/3.0.x
its post time gets updated when there is a git commit.
so for example last commit was from 17 Apr and the post time got updated to "Tuesday, April 18, 2023 9:08:27 AM"
but in freshrss checking for update doesn't change the post to unread. and it stays on the last time that post was added (or when the feed was added to freshrss) so in my case that is in Feb.

Expected behavior
the post should change to unread.

Environment information (please complete the following information):

Device: arm odroid xu4

OS: archlinux-arm

Browser: firefox

FreshRSS version: 1.23.1
php-sqlite 8.3.6-1
sqlite  sqlite 3.45.3
PHP version: 8.3.6

Installation type: self-hosted

when frehsrss has the option to make a post as unread if updated does that include checking for change of time for post too?

math-GH · 2024-05-09T09:58:56Z

math-GH
May 9, 2024
Collaborator

0 replies

rezad1393 · 2024-05-09T17:11:35Z

rezad1393
May 9, 2024
Author

tried that.
didnt work.

0 replies

math-GH · 2024-05-09T22:27:49Z

math-GH
May 9, 2024
Collaborator

Oh I see, that you are using FreshRSS 1.21.0.

Current version is 1.23.1

Maybe it was solve there

0 replies

rezad1393 · 2024-05-09T23:44:15Z

rezad1393
May 9, 2024
Author

Oh I see, that you are using FreshRSS 1.21.0.

Current version is 1.23.1

Maybe it was solve there

sorry I copied the info from bug report I created last year here #5347

my installation in current.

0 replies

math-GH · 2024-05-10T08:09:41Z

math-GH
May 10, 2024
Collaborator

Let's do it structured.

This is a snapshot from now:

<?xml version="1.0" encoding="UTF-8"?>
<feed xmlns="http://www.w3.org/2005/Atom" xmlns:media="http://search.yahoo.com/mrss/" xml:lang="en-US">
  <id>tag:github.com,2008:https://github.com/0x90d/videoduplicatefinder/releases</id>
  <link type="text/html" rel="alternate" href="https://github.com/0x90d/videoduplicatefinder/releases"/>
  <link type="application/atom+xml" rel="self" href="https://github.com/0x90d/videoduplicatefinder/releases.atom"/>
  <title>Release notes from videoduplicatefinder</title>
  <updated>2021-08-17T11:20:51Z</updated>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/3.0.x</id>
    <updated>2024-05-07T11:38:48Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/3.0.x"/>
    <title>3.0.x</title>
    <content type="html">&lt;p&gt;Note: These are daily builds. Attachments are automatically created and replaced on every new commit. Regardless of what the message above says. If you experience upgrade issues you may need to delete your &#39;ScannedFiles.db&#39; file in VDF folder.&lt;br&gt;
Last build based on&lt;/p&gt;</content>
    <author>
      <name>github-actions[bot]</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/in/15368?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.8</id>
    <updated>2020-09-03T18:51:39Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.8"/>
    <title>Video Duplicate Finder 2.0.8</title>
    <content>No content.</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.7</id>
    <updated>2019-04-30T11:06:32Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.7"/>
    <title>Video Duplicate Finder 2.0.7</title>
    <content>No content.</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.6</id>
    <updated>2019-02-21T15:10:34Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.6"/>
    <title>Video Duplicate Finder 2.0.6</title>
    <content>No content.</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.5</id>
    <updated>2019-02-19T18:35:47Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.5"/>
    <title>2.0.5</title>
    <content type="html">&lt;p&gt;Assembly and publish profile cleanup - drop 32bit build&lt;/p&gt;</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.4</id>
    <updated>2019-01-25T11:58:31Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.4"/>
    <title>Video Duplicate Finder 2.0.4</title>
    <content type="html">&lt;p&gt;Hotfix for wrong / missing video height information&lt;/p&gt;</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.3</id>
    <updated>2019-01-24T15:46:18Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.3"/>
    <title>2.0.3</title>
    <content type="html">&lt;p&gt;Update translations&lt;/p&gt;</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.2</id>
    <updated>2019-01-14T20:21:19Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.2"/>
    <title>2.0.2</title>
    <content type="html">&lt;p&gt;Console - return on database cleanup&lt;/p&gt;</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.1</id>
    <updated>2019-01-12T19:31:24Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.1"/>
    <title>Video Duplicate Finder 2.0.1</title>
    <content>No content.</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.x</id>
    <updated>2019-01-12T14:41:35Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.x"/>
    <title>2.0.x</title>
    <content type="html">&lt;p&gt;Update README.md&lt;/p&gt;</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
</feed>

Let's check it in some days

0 replies

rezad1393 · 2024-05-11T03:44:33Z

rezad1393
May 11, 2024
Author

Let's do it structured.

This is a snapshot from now:

<?xml version="1.0" encoding="UTF-8"?>
<feed xmlns="http://www.w3.org/2005/Atom" xmlns:media="http://search.yahoo.com/mrss/" xml:lang="en-US">
  <id>tag:github.com,2008:https://github.com/0x90d/videoduplicatefinder/releases</id>
  <link type="text/html" rel="alternate" href="https://github.com/0x90d/videoduplicatefinder/releases"/>
  <link type="application/atom+xml" rel="self" href="https://github.com/0x90d/videoduplicatefinder/releases.atom"/>
  <title>Release notes from videoduplicatefinder</title>
  <updated>2021-08-17T11:20:51Z</updated>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/3.0.x</id>
    <updated>2024-05-07T11:38:48Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/3.0.x"/>
    <title>3.0.x</title>
    <content type="html">&lt;p&gt;Note: These are daily builds. Attachments are automatically created and replaced on every new commit. Regardless of what the message above says. If you experience upgrade issues you may need to delete your &#39;ScannedFiles.db&#39; file in VDF folder.&lt;br&gt;
Last build based on&lt;/p&gt;</content>
    <author>
      <name>github-actions[bot]</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/in/15368?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.8</id>
    <updated>2020-09-03T18:51:39Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.8"/>
    <title>Video Duplicate Finder 2.0.8</title>
    <content>No content.</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.7</id>
    <updated>2019-04-30T11:06:32Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.7"/>
    <title>Video Duplicate Finder 2.0.7</title>
    <content>No content.</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.6</id>
    <updated>2019-02-21T15:10:34Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.6"/>
    <title>Video Duplicate Finder 2.0.6</title>
    <content>No content.</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.5</id>
    <updated>2019-02-19T18:35:47Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.5"/>
    <title>2.0.5</title>
    <content type="html">&lt;p&gt;Assembly and publish profile cleanup - drop 32bit build&lt;/p&gt;</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.4</id>
    <updated>2019-01-25T11:58:31Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.4"/>
    <title>Video Duplicate Finder 2.0.4</title>
    <content type="html">&lt;p&gt;Hotfix for wrong / missing video height information&lt;/p&gt;</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.3</id>
    <updated>2019-01-24T15:46:18Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.3"/>
    <title>2.0.3</title>
    <content type="html">&lt;p&gt;Update translations&lt;/p&gt;</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.2</id>
    <updated>2019-01-14T20:21:19Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.2"/>
    <title>2.0.2</title>
    <content type="html">&lt;p&gt;Console - return on database cleanup&lt;/p&gt;</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.1</id>
    <updated>2019-01-12T19:31:24Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.1"/>
    <title>Video Duplicate Finder 2.0.1</title>
    <content>No content.</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/164539637/2.0.x</id>
    <updated>2019-01-12T14:41:35Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/0x90d/videoduplicatefinder/releases/tag/2.0.x"/>
    <title>2.0.x</title>
    <content type="html">&lt;p&gt;Update README.md&lt;/p&gt;</content>
    <author>
      <name>0x90d</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/46010672?s=60&amp;v=4"/>
  </entry>
</feed>

Let's check it in some days

again, it doesnt update to newest version.

this is my feed in frehsrss.
when I manually press update feed on feed option it doesnt find new (updated date 2024-05-07T11:38:48Z ) for that top post.

2 replies

math-GH May 11, 2024
Collaborator

I understand your frustration. Please keep relaxed. Concrete data helps to understand the problem. There are algorithms working that tries do analyze if the feed changed or not.

rezad1393 May 11, 2024
Author

oh,was my tone angry or frustrated?

I am happy that you are helping with this and the lack of info from my part is what caused the first misunderstanding.

it is only one feed and I am not in a hurry and this is a free software and I mostly report issues to make software better and not really expect servitude from volunteers helping.

take your time.

I only reported this because I have a concrete bug that I can reproduce (old post that doesn't get updated) and want to make freshrss better.

usually my issue reporting is bad and not really concrete.

Alkarex · 2024-05-11T21:32:34Z

Alkarex
May 11, 2024
Maintainer

At the moment, we do not use the updated field for detecting a change, but rather check whether there has been a change in the content:

FreshRSS/app/Models/Entry.php

Line 437 in fa731db

 $this->hash = md5($this->link . $this->title . $this->authors(true) . $this->originalContent() . $this->tags(true)); 

We could store that information into the entry attributes via SimplePie's get_updated_date() function.
Edit: in this case, since there is no other date, just checking whether the date has changed should be enough.

We should however test whether that does not trigger too many false positives. We indeed typically have the opposite problems, namely of marking as unread too often...

1 reply

Frenzie May 11, 2024
Collaborator

I think in a GitHub context it could mean a new artifact was added. But if that's not reflected in the feed content it'd definitely feel like a false positive even if it strictly speaking wasn't.

rezad1393 · 2024-05-11T21:42:31Z

rezad1393
May 11, 2024
Author

I think in a GitHub context it could mean a new artifact was added. But if that's not reflected in the feed content it'd definitely feel like a false positive even if it strictly speaking wasn't.

I am not familiar with artifact but that repo create a new binary every time a commit is added but instead of a new rss post it just replaces the last release

0 replies

rezad1393 · 2024-05-11T21:44:36Z

rezad1393
May 11, 2024
Author

At the moment, we do not use the updated field for detecting a change, but rather check whether there has been a change in the content:

FreshRSS/app/Models/Entry.php

Line 437 in fa731db

$this->hash = md5($this->link . $this->title . $this->authors(true) . $this->originalContent() . $this->tags(true));

We could store that information into the entry attributes via SimplePie's get_updated_date() function. Edit: in this case, since there is no other date, just checking whether the date has changed should be enough.

We should however test whether that does not trigger too many false positives. We indeed typically have the opposite problems, namely of marking as unread too often...

I would have thought that it was the opposite, you know, first checking the date.

do feeds content change without date change?

doesnt rss software run on the host that creates rss feeds usually updates the date automatically when the author changes the post content??

0 replies

math-GH · 2024-05-12T14:08:58Z

math-GH
May 12, 2024
Collaborator

Here is a solution, that solves your issue too:

commits.atom has all commits into the main branch.

For FreshRSS: https://github.com/FreshRSS/FreshRSS/commits.atom
For your videoduplicatefinder: https://github.com/0x90d/videoduplicatefinder/commits.atom

It is much more useful than watching this strange used release RSS feed.

1 reply

rezad1393 May 12, 2024
Author

I have already done that.

I just wanted to help freshrss get better.
as I said before.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

github updated post doesnt get marked as unread #6443

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 10 comments 4 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

github updated post doesnt get marked as unread #6443

rezad1393 May 9, 2024

Replies: 10 comments · 4 replies

math-GH May 9, 2024 Collaborator

rezad1393 May 9, 2024 Author

math-GH May 9, 2024 Collaborator

rezad1393 May 9, 2024 Author

math-GH May 10, 2024 Collaborator

rezad1393 May 11, 2024 Author

math-GH May 11, 2024 Collaborator

rezad1393 May 11, 2024 Author

Alkarex May 11, 2024 Maintainer

Frenzie May 11, 2024 Collaborator

rezad1393 May 11, 2024 Author

rezad1393 May 11, 2024 Author

math-GH May 12, 2024 Collaborator

rezad1393 May 12, 2024 Author

rezad1393
May 9, 2024

Replies: 10 comments 4 replies

math-GH
May 9, 2024
Collaborator

rezad1393
May 9, 2024
Author

math-GH
May 9, 2024
Collaborator

rezad1393
May 9, 2024
Author

math-GH
May 10, 2024
Collaborator

rezad1393
May 11, 2024
Author

math-GH May 11, 2024
Collaborator

rezad1393 May 11, 2024
Author

Alkarex
May 11, 2024
Maintainer

Frenzie May 11, 2024
Collaborator

rezad1393
May 11, 2024
Author

rezad1393
May 11, 2024
Author

math-GH
May 12, 2024
Collaborator

rezad1393 May 12, 2024
Author