-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocked access to api.freemius.com
just fails without notice
#684
Comments
The problem causes a Fatal Error (at least on new PHP versions)
|
Use this snippet for a quick test: add_filter(
'pre_http_request',
function ( $bool, $r, $url ) {
if ( false !== strpos( $url, '//api.freemius.com' ) ) {
return new WP_Error( 'http_blocked', esc_html__( 'A valid URL was blocked.' ) );
}
return $bool;
},
100,
3
); |
+1 to fix |
We obviously have error handling in place. I'm unsure why the error wasn't triggered. The team will try to reproduce it and fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
馃悶 bug report
Behavior:
What is the issue? (*)
Some hosts block requests to other domains for "security" reasons. This happens with
api.freemius.com
as well. The problem is that there's no visual feedback on the actication screen so users have no idea what's going on.In this video I block access to
api.freemius.com
:s26NH5.mp4
What is the expected behavior?
An error message should show up explaining that access to
api.freemius.com
is needed for activation and updatesVersions: (*)
Freemius SDK Version:
2.6.2WordPress Version:
6.4.2PHP Version:
8.2The text was updated successfully, but these errors were encountered: