Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

The upgrade notice should only appear when the new version is higher than the version on the upgrade notice #668

Open
daigo75 opened this issue Nov 20, 2023 · 0 comments

Comments

@daigo75
Copy link

daigo75 commented Nov 20, 2023

馃悶 bug report

Behavior:
When a plugin includes an upgrade notice in the readme.txt file, the notice should only be displayed when upgrading from a lower version. For example, if the readme contains the following notice:

== Upgrade Notice ==

= 5.0 =
This is a major update, we recommend to test it update on a staging site first. Should you encounter any issue, please feel free to [contact our Support Team](https://aelia.co/contact).

The notice should only appear when the installed plugin version is lower than 5.0. The notice should not be displayed when the installed version is already 5.0 or higher.

Current behaviour
The upgrade notice is always displayed, even if the installed plugin version is equal or higher to the version to which the notice applies (see https://prnt.sc/kR39ZU1xheed).

Expected behaviour
The notice should only appear when the installed plugin version is lower than the one to which the notice applies.

Versions: (*)

  • Freemius SDK Version: 2.5.3
  • WordPress Version: 6.0 to 6.4
  • PHP Version: 8.x

Plugin / Theme: (*)

  • Name: Any
  • Freemius ID: Any

Note
The plugin itself is not relevant, in this case. The issue applies to all the plugins that add an upgrade notice to the readme file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant