Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freemius::_module_type should not be used directly in translations. #642

Open
TobiasBg opened this issue Jul 5, 2023 · 0 comments
Open

Comments

@TobiasBg
Copy link

TobiasBg commented Jul 5, 2023

In the sprintf() call

sprintf(
$this->get_text_inline( 'We made a few tweaks to the %s, %s', 'few-plugin-tweaks' ),
$this->_module_type,
sprintf( '<b><a href="%s">%s</a></b>',
$this->get_activation_url(),
sprintf( $this->get_text_inline( 'Opt in to make "%s" better!', 'optin-x-now' ), $this->get_plugin_name() )
)
),
, the variable $this->_module_type (usually "plugin" or "theme") gets inserted into the string directly, without being translatable.

This causes issues e.g. in German, where these should be "Plugin" and "Theme" then.

Please use the translated form here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant