/*#__PURE__*/ annotations don't play well with Vite / Rollup

[andrearonsen]

Describe the bug
When building a project with Vite 5 and Rollup, the following non-blocking warnings are outputted:

vite v5.0.10 building for production...
node_modules/victory-core/es/victory-primitives/rect.js (16:2) A comment

"/*#__PURE__*/"

in "node_modules/victory-core/es/victory-primitives/rect.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/victory-core/es/victory-primitives/rect.js (21:2) A comment

"/*#__PURE__*/"

in "node_modules/victory-core/es/victory-primitives/rect.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/victory-core/es/victory-primitives/clip-path.js (5:2) A comment

"/*#__PURE__*/"

in "node_modules/victory-core/es/victory-primitives/clip-path.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/victory-core/es/victory-primitives/circle.js (16:2) A comment

"/*#__PURE__*/"

in "node_modules/victory-core/es/victory-primitives/circle.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/victory-core/es/victory-primitives/circle.js (21:2) A comment

"/*#__PURE__*/"

in "node_modules/victory-core/es/victory-primitives/circle.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/victory-core/es/victory-primitives/line.js (16:2) A comment

"/*#__PURE__*/"

in "node_modules/victory-core/es/victory-primitives/line.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/victory-core/es/victory-primitives/line.js (21:2) A comment

"/*#__PURE__*/"

in "node_modules/victory-core/es/victory-primitives/line.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/victory-core/es/victory-primitives/path.js (17:2) A comment

"/*#__PURE__*/"

in "node_modules/victory-core/es/victory-primitives/path.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/victory-core/es/victory-primitives/path.js (22:2) A comment

"/*#__PURE__*/"

in "node_modules/victory-core/es/victory-primitives/path.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.

Victory version
36.7.0

To Reproduce
Steps to reproduce the behavior:

1. yarn create vite
   ✔ Project name: … test-victory-warns
   ✔ Select a framework: › React
   ✔ Select a variant: › TypeScript + SWC
2. cd test-victory-warns
3. yarn
4. yarn add victory
5. Edit App.tsx: import { VictoryBar } from "victory”; and <VictoryBar />
6. yarn build
7. See the warnings

Expected behavior
No warnings.

[carbonrobot]

Could you share a reproduceable example or at least the rollup/vite configs?

[andrearonsen]

Example:

1. yarn create vite
✔ Project name: … test-victory-warns
✔ Select a framework: › React
✔ Select a variant: › TypeScript + SWC
2. cd test-victory-warns
3. yarn
4. yarn add victory
5. Edit App.tsx: import { VictoryBar } from "victory”; and <VictoryBar />
6. yarn build
7. See the warnings

[carbonrobot]

Related to https://rollupjs.org/migration/#general-changes and rollup/rollup#5024

[carbonrobot]

I have a working solution for this, will get it published soon!