-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default_xyz_precision
and default_e_precision
set to 6 if specified
#72
Comments
fieldOfView
added a commit
to fieldOfView/Cura-ArcWelderPlugin
that referenced
this issue
Jul 16, 2021
These arguments are currently broken in ArcWelderLib. See FormerLurker/ArcWelderLib#72
Will check this out today, thanks for reporting! |
You are 100% correct. And there were more issues hiding in there. I just made a ton of changes, and have been testing almost exclusively via the OctoPrint app. I'm working on some of the other stuff now, and will post back once this is resolved. |
Ok, I just pushed a fix to devel. I've got more testing to do, but I think this issue is solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Specifying the
--default_xyz_precision
or--default_e_precision
options always results in a value of 6 being used.In https://github.com/FormerLurker/ArcWelderLib/blob/master/ArcWelderConsole/ArcWelderConsole.cpp#L135 and https://github.com/FormerLurker/ArcWelderLib/blob/master/ArcWelderConsole/ArcWelderConsole.cpp#L141, the
--default_xyz_precision
or--default_e_precision
options are defined as unsigned char, so they are parsed as (ascii) characters instead of ints. In my understanding this means that specifying a 0 will result in a value of 48 being parsed.The text was updated successfully, but these errors were encountered: