Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Srcset Images not generated correctly #1106

Open
DavidCzadilek opened this issue Aug 29, 2016 · 2 comments
Open

Srcset Images not generated correctly #1106

DavidCzadilek opened this issue Aug 29, 2016 · 2 comments

Comments

@DavidCzadilek
Copy link

Related to #1099

When defining width and height both with crop, srcset images are not generated correctly.

This code generates 200x200 cropped images, as it should:
<v:media.image src="{column.media}" alt="test" width="200c" height="200c" relative="0" treatIdAsReference="1" />

This code generates "non-square" images with a max-width of 200 - should be squared though:
<v:media.image src="{column.media}" alt="test" width="200c" height="200c" srcset="200,300,400,500" relative="0" treatIdAsReference="1" />

This code doesn't work at all / generates img tags with empty src attr.:
<v:media.image src="{column.media}" alt="test" width="200c" height="200c" srcset="200c,300c,400c,500c" relative="0" treatIdAsReference="1" />

@misterboe
Copy link
Contributor

@sophiequ
Copy link

Any news on this? I am facing the same problem and do not want to rely on coming up with my own partial. This must obviously be some bug in the VHS viewhelper. I am currently using the master version and the problem is still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants