Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Which filter should we use CIColorCube or CIColorCubeWithColorSpace? #82

Open
muukii opened this issue Mar 30, 2021 · 4 comments
Open

Which filter should we use CIColorCube or CIColorCubeWithColorSpace? #82

muukii opened this issue Mar 30, 2021 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@muukii
Copy link
Collaborator

muukii commented Mar 30, 2021

No description provided.

@muukii muukii added the help wanted Extra attention is needed label Mar 30, 2021
@elteclagol
Copy link

elteclagol commented Mar 30, 2021 •
edited

I don't know the technical differences between them, but when I use CIColorCubeWithColorSpace (CGColorSpaceCreateDeviceRGB()) the results are the expected and when I use CIColorCube they aren't. So I think CIColorCubeWithColorSpace is the answer.

@muukii
Copy link
Collaborator Author

muukii commented Mar 30, 2021

the results are the expected and when I use CIColorCube they aren't. So I think CIColorCubeWithColorSpace is the answer.

Yeah, I also faced this issue. that's why I choose withColorSpace.

@muukii
Copy link
Collaborator Author

muukii commented Mar 30, 2021

anyway, CoreImage's documentations are not helpful in those cases.
It could be I can ask Apple developer on this year WWDC.

@muukii
Copy link
Collaborator Author

muukii commented Apr 11, 2021

CIColorCubeWithColorSpace does matching color-space internally.
So I guess, CIColorCube and CIImage.matchedToWorkingSpace(from:) might be same with CIColorCubeWithColorSpace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@muukii @elteclagol