[BUG] Bug in WPOrm causes overwritting of model events.

[calvinalkan]

Right now its only possible to register one callback per model event.

Ever successive call to Mode::registerModelEvent() will overwritte all previous callbacks.

Current code:

  public static function registerModelEvent($event, $callback)
    {
        $calledClass = static::getCalledClassName();
        static::$events["model.{$calledClass}.{$event}"] = $callback;
    }

What it should be:

public static function registerModelEvent($event, $callback)
    {
        $calledClass = static::getCalledClassName();
        static::$events["model.{$calledClass}.{$event}"][] = $callback;
    }

And then also something like this:

  public function fireModelEvent($event)
    {
        $calledClass = static::getCalledClassName();
        $eventName = "model.{$calledClass}.{$event}";

        $return = null;
        if (isset(static::$events[$eventName])) {
    
            foreach (static::$events[$eventName] as $callback) {
                
                $return = call_user_func($callback, $this);
                
                if( $return === false ) {
                    return false;
                }
            }
            
            return $return;
        }
    }

I assume you did not intend it to work this way to only be able to register one event per model action. Its kinda limiting and the fix is easy and non-breaking

[techjewel]

Thanks for letting me know. I am tagging our CTO in this issue.
@heera