-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diff_match_patch.py references old urllib.parse, breaking in ST3 build 3126 #241
Comments
I'm very confused by this. I'm using the same platform (Ubuntu 17.04) & build of Sublime (3126) and I can collaborate just fine. Maybe another plugin is monkey patching urllib? |
Same issue for me (ArchLinux, sublime 3143) |
Same probleme here, (Ubuntu 14.04.5 LTS) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Spent the last hour poking around about this. I saw a few issues in this repo discussed by @wbond and some others, and while it appears that this was working with ST3 build 3120, the current stable build (3126) is not working again, and I cannot install Floobits either via package installer or manually via git.
It seems that the issue is the splitting of the
urllib
module, discussed on this SO post: https://stackoverflow.com/a/29358613(Relevant PY3 docs: https://docs.python.org/3.3/library/urllib.parse.html#module-urllib.parse )
My instance of ST3 is indeed using PY3 v3.3.6
and
urllib
is sourcing from there as well:In file
.../Floobits/floo/common/lib/diff_match_patch.py
, line 32, it has this:The
from urllib import parse
seems to be the offending line; and it looks like the script is trying to gracefully accommodate that in the exception blockimport urllib as parse
.Attempting these in the ST3 terminal, I get:
However, in 3.3, these methods are found in the
urllib.parse
module, and I was able to get a confirmation of loading forparse.unquote
by doing this:So it appears that these methods are available, but the existing code in that file (
.../diff_match_patch.py
) is not importing them correctly.Just on a lark, I tried changing that opening block to:
And then did a find/replace (
s/parse.quote/quote/
).When I closed and reopened ST3, the errors about
urllib.parse
were no longer showing, however I did see a couple other errors related to urllib, including:and
So I suspect that the module refactoring they did in this version has had some effects in other places as well.
I'm super rusty in python (and am looking through this repo for the first time ever tonight) and while I'd be happy to submit a PR for these superficial changes, someone more experienced should really audit this as well.
Happy to answer any followup questions about this issue or provide additional information, if that's needed. (I'm on Ubuntu 17.04)
The text was updated successfully, but these errors were encountered: