Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passReqToCallback #1

Open
jaysw opened this issue Mar 12, 2015 · 1 comment
Open

passReqToCallback #1

jaysw opened this issue Mar 12, 2015 · 1 comment

Comments

@jaysw
Copy link
Contributor

jaysw commented Mar 12, 2015

Hi!

I think you have a problem in your jwtVerify() method when options.passReqToCallback = true -- in this case you would need to check for the "request" in the first argument to jwtVerify() here:

https://github.com/FloeDesignTechnologies/passport-http-jwt-bearer/blob/master/lib/strategy.js#L80

This relates to how passport-http-bearer makes the call to verify(), see here:

https://github.com/jaredhanson/passport-http-bearer/blob/master/lib/strategy.js#L129

Cheers,

Jay.

@pbuyle
Copy link
Member

pbuyle commented Apr 1, 2015

Sorry for the delay, I missed this issue report. I'll merge pull request #2, but test cases and documentation are needed for the issue to be completely resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants