Move confirm delete row and before delete row check to util #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KollegOFF
reviewed
Feb 6, 2021
| /** | ||
| Used for check confirm delete rows function and get result. | ||
|
|
||
| @method checkConfirmDeleteRows |
There was a problem hiding this comment.
Suggested change
| @method checkConfirmDeleteRows | |
| @private | |
| @method checkConfirmDeleteRows |
| /** | ||
| Used for check before delete record function and get result. | ||
|
|
||
| @method checkBeforeDeleteRecord |
There was a problem hiding this comment.
Suggested change
| @method checkBeforeDeleteRecord | |
| @private | |
| @method checkBeforeDeleteRecord |
| Ember.assert('Error: beforeDeleteRecord must be a function', typeof beforeDeleteRecordFunction === 'function'); | ||
| let promis = beforeDeleteRecordFunction(record, data); | ||
| possiblePromise = (promis && (promis instanceof Ember.RSVP.Promise)) ? promis : possiblePromise; | ||
| possiblePromise = (data.cancel) ? null : possiblePromise; |
There was a problem hiding this comment.
Проверку data.cancel видимо придётся оставить за функцией, потому что это нужно проверять только после резолва промиса.
| @@ -80,7 +80,6 @@ | |||
| filterByAllWords=filterByAllWords | |||
| configurateRow=this.attrs.configurateRow | |||
| configurateSelectedRows=this.attrs.configurateSelectedRows | |||
| confirmDeleteRow=confirmDeleteRow | |||
There was a problem hiding this comment.
Пока только устарело, нужно оставить.
| @@ -120,7 +120,6 @@ | |||
| filterByAllWords=filterByAllWords | |||
| configurateRow=this.attrs.configurateRow | |||
| configurateSelectedRows=this.attrs.configurateSelectedRows | |||
| confirmDeleteRow=confirmDeleteRow | |||
Comment on lines
+49
to
+51
| let funcTest = function() { | ||
| return true; | ||
| }; |
There was a problem hiding this comment.
Не хватает вариантов когда эти функции возвращают ложные значения и промисы.
|
Исправить для 3 версии |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.