Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc23 version tag #10

Open
Kynea0b opened this issue Feb 7, 2024 · 0 comments
Open

ibc23 version tag #10

Kynea0b opened this issue Feb 7, 2024 · 0 comments

Comments

@Kynea0b
Copy link

Kynea0b commented Feb 7, 2024

ics23

In this repository, ics23 submodule uses this.
https://github.com/cosmos/ics23/tree/rust/v0.10.0/proto

When building the proto files of this submodule with "packages/proto-build", the tag is fixed value "rust/v0.10.0".

We actually want to write the tag extracted from finschia to the env file and use it, but ibc is not yet supported in finschia, so we suspend it.

Currently, fisnchia is referencing this old repository.
https://github.com/Finschia/finschia/blob/main/go.mod#L40

Once ibc is supported, make changes to ".github/workflows/update-and-rebuild.yaml" and "packages/proto-build" to use the tags referenced by finschia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant