Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of dimension restriction? #116

Open
dkarrasch opened this issue Jun 21, 2019 · 1 comment
Open

Get rid of dimension restriction? #116

dkarrasch opened this issue Jun 21, 2019 · 1 comment

Comments

@dkarrasch
Copy link

I was recommending this package in a fantastic WIP JuliaManifolds/Manifolds.jl#12, but forgot that there is a restriction on dim. A brief check seems to indicate that one could in principle get rid of that restriction, since many operators are written in terms of loops i = 1:dim and would work right away. It seems that only a few functions (like inv) are currently written assuming dim in (1, 2, 3). Would you consider PRs to the effect of getting rid of the dimension restriction? One could let certain continuum mechanics-related functions be restricted to dim in (1, 2, 3) and throw errors otherwise?

@fredrikekre
Copy link
Member

Could be interesting to play around with if you like. What kind of dimensions are we talking about? The same number-of-element restrictions as with e.g. StaticArrays.jl holds for Tensors.jl too, and tensors with more than ~100 or so elements quickly becomes slow and you are better off with regular Arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants