Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming of reference shape in docs #946

Open
KnutAM opened this issue May 23, 2024 · 1 comment
Open

Naming of reference shape in docs #946

KnutAM opened this issue May 23, 2024 · 1 comment
Labels

Comments

@KnutAM
Copy link
Member

KnutAM commented May 23, 2024

As discovered in #935, we currently denote AbstractRefShape in the docs as

  • reference shapes
  • reference cells
  • reference elements

I would suggest to make this consistent throughout the docs in a pure rename PR, and since the type is AbstractRefShape suggest using the first name consistently.

@termi-official
Copy link
Member

Related to this, so I answer here. Maybe we should add in the nomenclature section (xref #944) and maybe in the beginning the relation between the wordings, as newcomers might wonder about why we do not call everything Element in the finite element method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants