Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update topology example #1035

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update topology example #1035

wants to merge 4 commits into from

Conversation

KristofferC
Copy link
Collaborator

Fixes #1031

@codecov Codecov
Copy link

codecov bot commented Aug 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.61%. Comparing base (98e2b67) to head (e8d382c).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1035      +/-   ##
==========================================
+ Coverage   93.60%   93.61%   +0.01%     
==========================================
  Files          39       39              
  Lines        5883     5893      +10     
==========================================
+ Hits         5507     5517      +10     
  Misses        376      376

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristofferC
Copy link
Collaborator Author

Not sure what is going on with the doc build...

Run julia --project=docs -e 'using Pkg; Pkg.instantiate(); Pkg.precompile()'
   Installed ArraysOfArrays ─ v0.6.5
Precompiling project...
  ✓ ArraysOfArrays
  ✓ ArraysOfArrays → ArraysOfArraysStaticArraysCoreExt
  ✗ LazyArrays → LazyArraysBlockArraysExt
  ✓ ArraysOfArrays → ArraysOfArraysAdaptExt
  ✓ ArraysOfArrays → ArraysOfArraysChainRulesCoreExt
  ✓ Ferrite
  ✗ Ferrite → FerriteBlockArrays
  ✓ FerriteMeshParser
  ✓ FerriteGmsh
  7 dependencies successfully precompiled in 8 seconds. 346 already precompiled.

The following 1 direct dependency failed to precompile:

BlockArrays [8e7c35d0-a365-5155-bbbb-fb81a777f[2](https://github.com/Ferrite-FEM/Ferrite.jl/actions/runs/10195746128/job/28205064552?pr=1035#step:5:2)4e]

Error: Missing source file for BlockArrays [8e7c35d0-a365-5155-bbbb-fb81a777f24ePrecompiling project...

@termi-official
Copy link
Member

I had the exact same issue a while ago with the docs with Julia 10.4. It turned out that the dependency (FerriteMeshParser) was only partially downloaded. Found this by manually inspecting the depot folder (.julia/package/FerriteMeshParser). I could come up with a reproducer and eventually forgot about it.

@KnutAM
Copy link
Member

KnutAM commented Aug 1, 2024 •
edited
Loading

Not sure what is going on with the doc build...

Perhaps? (Not the best error message in that case, trying to Pkg.update gave better error)

- git-tree-sha1 = "5c0ffe1dff8cb7112de075f1b1cb32191675fcba"
+ path = "dev/BlockArrays"

https://github.com/Ferrite-FEM/Ferrite.jl/pull/1035/files#diff-54a801f523c8f767061bbcd8c8da625a8d8ce3354a1513a7d674badb77fa14e9R154

@KristofferC
Copy link
Collaborator Author

Ah, thanks, that was not intended to commit. Weird that Pkg didn't complain about that indeed.

KnutAM
KnutAM approved these changes Aug 3, 2024
View reviewed changes
Copy link
Member

@KnutAM KnutAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor suggestions.

Are there any measureable improvements when not creating many Vectors{Vectors} here as well? In that case, perhaps a small comment would be nice for users to understand why we use VectorOfArrays?

docs/src/literate-gallery/topology_optimization.jl Outdated Show resolved Hide resolved
docs/src/literate-gallery/topology_optimization.jl Outdated
Comment on lines 191 to 192
# the function call will return an empty object. In that case we use the dictionary to instead find the opposite
# face, as discussed in the introduction.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above needs to reflect that a tuple is used I think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnutAM KnutAM KnutAM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Topology optimization example in code gallery should use better use of topology
3 participants
@KristofferC @termi-official @KnutAM