-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for serializing java.sql.Blob
#2925
Conversation
src/main/java/com/fasterxml/jackson/databind/deser/std/SqlBlobDeserializer.java
Show resolved
Hide resolved
Looks good, will merge. Thank you! |
java.sql.Blob
…va.sql.Blob to avoid add'l dependency Assumption is that serialization more likely needed; also since implementation of deser bit bare-bones, has issues; may be added if a user requests support.
java.sql.Blob
java.sql.Blob
Ended up dropping deserialization support from 2.12, as I think it gets tricky, requires new Java 9 module dependency, and has not yet been requested. There are also some technical things about deserialization itself to consider (it's not just json, so incoming value may be "true" binary or base64-encoded data etc). So will want to wait for it being requested -- should probably not have suggested addition yet. |
Dear Tatu,
Noted, I agree with you, the deserialization method I've made is too
specific for Base64 to Blob. Just a little suggestion from me, maybe you
can still keep the SqlBlobDeserialization class? So users can still use it
via @JsonDeserialize.
Any other feature that I can help? Or maybe I can help to add some unit
test?
Thanks,
Rizky
…On Tue, Nov 10, 2020 at 5:50 AM Tatu Saloranta ***@***.***> wrote:
Ended up dropping deserialization support from 2.12, as I think it gets
tricky, requires new Java 9 module dependency, and has not yet been
requested. There are also some technical things about deserialization
itself to consider (it's not just json, so incoming value may be "true"
binary or base64-encoded data etc). So will want to wait for it being
requested -- should probably not have suggested addition yet.
Serialization part may need improvement too, as actual Blob
implementations may not get mapped... but user feedback can help there.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2925 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADRFBKSZHOIG7YGOH7SU6QLSPBW2NANCNFSM4TNRDYVQ>
.
|
I think at this point users will need to have a look at PR, if they need to add it. If there was a convenient way to add example code I would include it; but otherwise I don't think I want to add unused code. That tends to lead to maintenance challenges. |
Hi,
My previous PR is missing because I delete my commit. Anyway, this PR is for serializer/deserializer SqlBlob into Base64 String. This will be very useful in cases send query result through json. What I have done since the last commit are:
Thanks,
Rizky