MSVC build version number reported

[mhitza]

@slspencer
The reported version number in the About Seamly2D section reports having been built with MSVC 2014, after spending time trying different builds to ensure that's not the case I've jumped in the source code to check how the value is reported.

Seamly2D/src/libs/vmisc/projectversion.cpp

Lines 119 to 128 in a034db9

	#elif defined(Q_CC_MSVC)
	if (_MSC_VER >= 1800) // 1800: MSVC 2013 (yearly release cycle)
	{
	return QLatin1String("MSVC ") + QString::number(2008 + ((_MSC_VER / 100) - 13));
	}
	if (_MSC_VER >= 1500) // 1500: MSVC 2008, 1600: MSVC 2010, ... (2-year release cycle)
	{
	return QLatin1String("MSVC ") + QString::number(2008 + 2 * ((_MSC_VER / 100) - 15));
	}
	#else

#elif defined(Q_CC_MSVC)
    if (_MSC_VER >= 1800) // 1800: MSVC 2013 (yearly release cycle)
    {
        return QLatin1String("MSVC ") + QString::number(2008 + ((_MSC_VER / 100) - 13));
    }
    if (_MSC_VER >= 1500) // 1500: MSVC 2008, 1600: MSVC 2010, ... (2-year release cycle)
    {
        return QLatin1String("MSVC ") + QString::number(2008 + 2 * ((_MSC_VER / 100) - 15));
    }
#else

Search for Visual Studio version at the following link
https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=vs-2019

The version used in the build pipeline is:

Visual Studio 2019 version 16.6	1926

If we run through the pasted code block, and replace _MSC_VER with 1926 and run through the code we see it will execute the first code block, and the following formula is applied:

2008 + ((1926 / 100) - 13) = 2014.26

In the end it seems to be an issue with the way the year is reported based on the MSVC version number.

[mhitza]

Actually, the Visual Studio version number currently used is 16.0, as seen in the output of the last release build https://github.com/FashionFreedom/Seamly2D/runs/774252298?check_suite_focus=true#step:5:18

_MSC_VER in that case is 1920, which in the original formula will return 2014.2

[slspencer]

I investigated using MSVC 2019 with Qt 5.13.2. It's not available for Qt 5.13.2, only MSVC 2015 & MSVC 2017. MSVC 2019 isn't distributed with Qt until version 5.15.0. Can you change the pipeline to use MSVC 2017?

[mhitza]

I've created a PR that changes the compiler toolset used during the build. https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B#Internal_version_numbering

Note that the automated Qt installation doesn't install the MSVC compiler as you can when installing it through a visual interface. At least not the aqt installer we're using, which seems to be the only way to automatically install Qt from the command line.

Also, note that there are only three versions of MSVC to chose from on the GitHub runner. I've ran a find command for the cl/nmake executables available on the system https://github.com/mhitza/Seamly2D/runs/790566818?check_suite_focus=true#step:3:46

The only versions available are:

• 14.0 (Visual Studio 2015 version 14.0)
• 14.16.27023 (Visual Studio 2017 version 15.9)
• 14.26.28801 (Visual Studio 2019 Version 16.6)