Modded creatures with ondeath status effect crash game on death without crashlog, modded human animated creatures crash server on spawn

[Draconis13]

Disclaimers

• I have searched the issue tracker to check if the issue has already been reported.
• My issue happened while using mods.

What happened?

either through event or spawncharacter a human animated creature is spawned or when a modded character with an ondeath status effect dies such as a Watcher with reduce watchers gaze affliction or explosion.

Reproduction steps

Load Barotraumatic Creatrure pack or another creature mod.

Spawncharacter with ondeath trigger such as Watcher, kill character via console/weapons game crashes no errorlog generated

Spawncharacter with human animation I.E. Barotraumatic Creature Pack Jovian Diver, Lost Clown, Husk Immortal Etc. Game crashes instantly and produces error log relating to Get Spritepath and Humanoidanimcontroller

Bug prevalence

Happens every time I play

Single player or multiplayer?

Happens in both single player and multiplayer

-

No response

Version

v1.5.7.0 (Summer Update)

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

Exception: Object reference not set to an instance of an object. (System.NullReferenceException)
Target site: System.String GetSpritePath(Barotrauma.ContentPath, Barotrauma.CharacterInfo)
Stack trace: 
   at Barotrauma.Limb.GetSpritePath(ContentPath texturePath, CharacterInfo characterInfo) in <DEV>\Barotrauma\BarotraumaClient\ClientSource\Characters\Limb.cs:line 531
   at Barotrauma.Limb.GetSpritePath(ContentXElement element, SpriteParams spriteParams, String& path) in <DEV>\Barotrauma\BarotraumaClient\ClientSource\Characters\Limb.cs:line 507
   at Barotrauma.Limb.InitProjSpecific(ContentXElement element) in <DEV>\Barotrauma\BarotraumaClient\ClientSource\Characters\Limb.cs:line 298
   at Barotrauma.Limb..ctor(Ragdoll ragdoll, Character character, LimbParams limbParams) in <DEV>\Barotrauma\BarotraumaShared\SharedSource\Characters\Limb.cs:line 744
   at Barotrauma.Ragdoll.AddLimb(LimbParams limbParams) in <DEV>\Barotrauma\BarotraumaShared\SharedSource\Characters\Animation\Ragdoll.cs:line 623
   at System.Collections.Generic.List`1.ForEach(Action`1 action)
   at Barotrauma.Ragdoll.CreateLimbs() in <DEV>\Barotrauma\BarotraumaShared\SharedSource\Characters\Animation\Ragdoll.cs:line 536
   at Barotrauma.Ragdoll.Recreate(RagdollParams ragdollParams) in <DEV>\Barotrauma\BarotraumaShared\SharedSource\Characters\Animation\Ragdoll.cs:line 415
   at Barotrauma.AnimController.Recreate(RagdollParams ragdollParams) in <DEV>\Barotrauma\BarotraumaShared\SharedSource\Characters\Animation\AnimController.cs:line 815
   at Barotrauma.HumanoidAnimController.Recreate(RagdollParams ragdollParams) in <DEV>\Barotrauma\BarotraumaShared\SharedSource\Characters\Animation\HumanoidAnimController.cs:line 216
   at Barotrauma.Ragdoll..ctor(Character character, String seed, RagdollParams ragdollParams) in <DEV>\Barotrauma\BarotraumaShared\SharedSource\Characters\Animation\Ragdoll.cs:line 467
   at Barotrauma.AnimController..ctor(Character character, String seed, RagdollParams ragdollParams) in <DEV>\Barotrauma\BarotraumaShared\SharedSource\Characters\Animation\AnimController.cs:line 225
   at Barotrauma.HumanoidAnimController..ctor(Character character, String seed, HumanRagdollParams ragdollParams) in <DEV>\Barotrauma\BarotraumaShared\SharedSource\Characters\Animation\HumanoidAnimController.cs:line 208
   at Barotrauma.Character..ctor(CharacterPrefab prefab, Vector2 position, String seed, CharacterInfo characterInfo, UInt16 id, Boolean isRemotePlayer, RagdollParams ragdollParams, Boolean spawnInitialItems) in <DEV>\Barotrauma\BarotraumaShared\SharedSource\Characters\Character.cs:line 1513
   at Barotrauma.AICharacter..ctor(CharacterPrefab prefab, Vector2 position, String seed, CharacterInfo characterInfo, UInt16 id, Boolean isNetworkPlayer, RagdollParams ragdoll, Boolean spawnInitialItems) in <DEV>\Barotrauma\BarotraumaShared\SharedSource\Characters\AICharacter.cs:line 15
   at Barotrauma.Character.Create(CharacterPrefab prefab, Vector2 position, String seed, CharacterInfo characterInfo, UInt16 id, Boolean isRemotePlayer, Boolean hasAi, Boolean createNetworkEvent, RagdollParams ragdoll, Boolean spawnInitialItems) in <DEV>\Barotrauma\BarotraumaShared\SharedSource\Characters\Character.cs:line 1306
   at Barotrauma.DebugConsole.SpawnCharacter(String[] args, Vector2 cursorWorldPos, String& errorMsg) in <DEV>\Barotrauma\BarotraumaShared\SharedSource\DebugConsole.cs:line 0
   at Barotrauma.DebugConsole.<>c.<InitProjectSpecific>b__23_41(String[] args) in <DEV>\Barotrauma\BarotraumaClient\ClientSource\DebugConsole.cs:line 873
   at Barotrauma.DebugConsole.Command.Execute(String[] args) in <DEV>\Barotrauma\BarotraumaShared\SharedSource\DebugConsole.cs:line 87
   at Barotrauma.DebugConsole.ExecuteCommand(String inputtedCommands) in <DEV>\Barotrauma\BarotraumaShared\SharedSource\DebugConsole.cs:line 2145
   at Barotrauma.DebugConsole.Update(Single deltaTime) in <DEV>\Barotrauma\BarotraumaClient\ClientSource\DebugConsole.cs:line 201
   at Barotrauma.GameMain.Update(GameTime gameTime) in <DEV>\Barotrauma\BarotraumaClient\ClientSource\GameMain.cs:line 950
   at Microsoft.Xna.Framework.Game.DoUpdate(GameTime gameTime) in E:\Barotrauma-development\Libraries\MonoGame.Framework\Src\MonoGame.Framework\Game.cs:line 656
   at Microsoft.Xna.Framework.Game.Tick() in E:\Barotrauma-development\Libraries\MonoGame.Framework\Src\MonoGame.Framework\Game.cs:line 500
   at Microsoft.Xna.Framework.SdlGamePlatform.RunLoop() in E:\Barotrauma-development\Libraries\MonoGame.Framework\Src\MonoGame.Framework\SDL\SDLGamePlatform.cs:line 93
   at Microsoft.Xna.Framework.Game.Run(GameRunBehavior runBehavior) in E:\Barotrauma-development\Libraries\MonoGame.Framework\Src\MonoGame.Framework\Game.cs:line 397
   at Microsoft.Xna.Framework.Game.Run() in E:\Barotrauma-development\Libraries\MonoGame.Framework\Src\MonoGame.Framework\Game.cs:line 367
   at Barotrauma.Program.Main(String[] args) in <DEV>\Barotrauma\BarotraumaClient\ClientSource\Program.cs:line 61

Last debug messages:
[06/18/2024 22:55:12] spawncharacter Joviandiver cursor

[Draconis13]

Hotfix patch fixed the infinite loop from OnDeath status effects however HumanoidAnimController is still throwing the error related to object reference not set to an instance of an object.

[Draconis13]

SOLVED: Legacy humanlike creature was missing portions that were being skipped by previous versions of the game.

By adding entirety of and tweaking base character info in charactername.xml and accounting for [Gender] in characternameragdoll.xml fake human characters properly spawn in instead of the previous gray bodied default human placeholder.

[Regalis11]

I'm glad you found a solution (or a workaround) by yourself! I pushed a fix to this to our private repo now (https://github.com/FakeFishGames/Barotrauma-development/commit/f464b16a6b9a1f909735791fdffd7f8811e2ed5b), which should prevent the crash in this situation. Coming up in a future update.

[Draconis13]

Seems to still be an issue for some reason when the game spawns this characters in vs when console spawns them in. They work perfectly in console but often they do not spawn in texture correctly saying the textures on not found on loading into the level resulting in enemies having invisible bodies and often only the head visible.