New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design improvement #8

Open

FabriceSalvaire opened this issue May 3, 2017 · 0 comments

Labels

enhancement PRIVATE thinking

Owner

FabriceSalvaire commented May 3, 2017 •

edited

Profiling: where are the hotspots (found pygments lexer issue, pygit2 warmup ???)
Is PyQt5 really suitable ?
Reimplement using QML ?
Is there a better diff viewer widget implementation ? Using QML ? Using QWebEngine ?

Actual design:

use http://doc.qt.io/qt-5/qtextbrowser.html to render the text and to get box size
use QSplitterHandle
overload painEvent on both QTextBrowser and QSplitterHandle to draw link lines

FabriceSalvaire added enhancement question labels

FabriceSalvaire added thinking and removed question labels

FabriceSalvaire added the PRIVATE label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment