Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can I update the HTML & CSS on the website? #261

Open
edent opened this issue Nov 14, 2024 · 1 comment
Open

Can I update the HTML & CSS on the website? #261

edent opened this issue Nov 14, 2024 · 1 comment

Comments

@edent
Copy link
Contributor

edent commented Nov 14, 2024

I've notice that the HTML & CSS for https://fosdem.org/2025/ is a little out of date.

  • Wrong doctype
  • Use of obsolete elements like <center>
  • Metadata not compliant with modern standards
  • Repeated use of <br> rather than CSS positioning
  • A few minor accessibility issues around contrast
  • Not mobile friendly
    screenshot showing elements cut off

Would it be OK if I send some PRs to modernise the HTML and fix some of the issues? I would keep the same look and feel, page structure, etc.
@kragniz
Copy link
Member

kragniz commented Nov 15, 2024

Yes please!

@edent edent mentioned this issue Nov 15, 2024
Merged
kragniz pushed a commit that referenced this issue Nov 17, 2024
@edent
HTML updates (#263)
8ae6f94 
This PR:

    Fixes most broken HTML
    Adds some semantic HTML (more to come if this is accepted)
    Makes phone numbers clickable
    Better support for mobile devices (front page still needs work)
    Corrects broken links
    Minor CSS improvements (more to come)
    Spelling corrections
    Alt text fixes
    Removes link to Twitter (hasn't been updated in years)

I've run nanoc and all the files compile and pass validation (nanoc likes putting stray /> at the end of some elements - but that doesn't break anything).

Visually, most pages stay the same. A few minor tweeks to allow pages to work on narrow screens.

Happy to make any changes.

Addresses #261

---------

Co-authored-by: Terence Eden <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kragniz @edent