Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Lines // in JavaScript Not Removed When Minifying #72

Open
mshannaq opened this issue Oct 31, 2023 · 0 comments
Open

Comment Lines // in JavaScript Not Removed When Minifying #72

mshannaq opened this issue Oct 31, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mshannaq
Copy link
Member

When the smartyurl.minifyHtmloutput setting is enabled (set to true), comment lines in JavaScript code that use // are not removed during the minification process. For example:

<script> // set the redirectCondition var redirectCondition = document.getElementById("redirectCondition"); redirectCondition.value = "device"; </script>

This can result in errors in the JavaScript code.

Suggested Solution:

If you're a SmartyURL developer or creating tools and UI for SmartyURL, we recommend using /* */ for comments in JavaScript output instead of // while we address this issue. This ensures proper comment handling during the minification process.

We appreciate your understanding, and we'll address this issue in an upcoming update.

@mshannaq mshannaq added bug Something isn't working enhancement New feature or request good first issue Good for newcomers and removed enhancement New feature or request labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant