Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which Polyfill to use? #1

Open
ff6347 opened this issue Mar 12, 2017 · 3 comments
Open

Which Polyfill to use? #1

ff6347 opened this issue Mar 12, 2017 · 3 comments
Assignees

Comments

@ff6347
Copy link
Member

ff6347 commented Mar 12, 2017

On MDN there is a different polyfill for Object.assign then the one we have currently. Which one should we use? https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign#Polyfill

I would vote for the MDN one.

@the-moisrex
Copy link

MDN would be my choice.

@EugenTepin
Copy link

For es5 shims, i get code mostly from MDN, and then rewrite it to fit Adobe js engine. In case of es6 shim the same approach is applicable.

@GitBruno
Copy link

Hey guys, I added a guideline about this in the extendscripters wiki.

ff6347 pushed a commit that referenced this issue Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants