Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FIPS code to counties from NYT source #314

Open
lxu213 opened this issue May 17, 2020 · 2 comments
Open

Add FIPS code to counties from NYT source #314

lxu213 opened this issue May 17, 2020 · 2 comments
Labels
enhancement New feature or request source: nyt New York Times

Comments

@lxu213
Copy link

lxu213 commented May 17, 2020

Currently, the counties from the NYT source are assigned IDs that don't abide to any standard. If they were assigned an FIPS county code which are used by the US Census Bureau to uniquely identify geographic features, it would be much easier to join, identify, and parse.

I'm not sure the best approach to implementing this while maintaining backwards compatibility. However if this is something others are also interested in and we can come up with a suitable strategy, I would be happy to open a PR for this if the team has the capacity to review it.

@Kilo59 Kilo59 added enhancement New feature or request source: nyt New York Times labels May 17, 2020
@Kilo59
Copy link
Collaborator

Kilo59 commented May 17, 2020

This sounds like a good idea.

I've been meaning to start a discussion thread about potentially a v3 of the API, we wouldn't need to worry about backward compatibility in that case.
I think being able to access the nested locations with sensible ids would be part of that.
GET v3/countries/<country_code> or just v3/<country_code>
GET v3/countries/<country_code>/<state/province>
GET v3/countries/<country_code>/<state/province>/<county_code/county_name>

Example

GET v3/us/texas/48015 or GET v3/us/texas/austin
Or even
GET v3/countries/us/states/texas/counties/austin

@lxu213
Copy link
Author

lxu213 commented May 18, 2020

@Kilo59 that's great a v3 of the API will be discussed soon! Being able to access either using FIPS county code or by using county name would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request source: nyt New York Times
Projects
None yet
Development

No branches or pull requests

2 participants