Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovered values all set to 0 #161

Open
mugetsu opened this issue Mar 24, 2020 · 25 comments
Open

Recovered values all set to 0 #161

mugetsu opened this issue Mar 24, 2020 · 25 comments
Labels
help wanted Extra attention is needed question Further information is requested source: jhu

Comments

@mugetsu
Copy link

mugetsu commented Mar 24, 2020

No description provided.

@ExpDev07 ExpDev07 added the question Further information is requested label Mar 24, 2020
@ExpDev07
Copy link
Owner

ExpDev07 commented Mar 24, 2020

Our main data provided (JHU) has decided to drop support for recovery data, hence, the API will show 0 until an alternative source is added for world data.

There’s a notice regarding this change on the top of the README. Unfortunately little I can do besides change data source, which again, many people will get upset with.

@jaime-chur
Copy link

Will this be fixed soon? :(

@ExpDev07
Copy link
Owner

@jaime-chur hopefully !

@dinesh-varyani
Copy link

"Our main data provided (JHU) has decided to drop support for recovery data" ... Where its mentioned ?
I can see JHU still has latest data (published few hours back) with recovered cases.

@ExpDev07
Copy link
Owner

@dinesh-varyani

We will no longer provide recovered cases.

(from CSSEGISandData/COVID-19#1250).

@codedawi
Copy link
Contributor

codedawi commented Mar 25, 2020

According to a recent interview IBM's CEO they are working on getting the recovered numbers for their new Weather Channel map to track coronavirus. They could be working with CDC to aggregate this data. This might be a creditable data source to get this recovery information from in the future.

@ExpDev07
Copy link
Owner

@codedawi Awesome!

@winsphinx
Copy link

Even in v1, the recovered data are dropped.

@ExpDev07
Copy link
Owner

ExpDev07 commented Mar 26, 2020

It seems like JHU are starting to track recoveries again (or at least they've added a file for it: https://github.com/CSSEGISandData/COVID-19/blob/master/csse_covid_19_data/csse_covid_19_time_series/time_series_covid19_recovered_global.csv), however, the indexing is not compatible with the confirmed and deaths so it won't show up in v2 yet and it also appears the file is a bit corrupted/broken. I'll give them some time to fix it then add back recoveries :).

See CSSEGISandData/COVID-19#1581 (comment).

@winsphinx

@Zrna
Copy link

Zrna commented Mar 26, 2020

@ExpDev07 will https://coronavirus-tracker-api.herokuapp.com/all be updated also?

@ExpDev07
Copy link
Owner

@Zrna yes.

@ExpDev07
Copy link
Owner

ExpDev07 commented Mar 26, 2020

@Zrna recoveries for https://coronavirus-tracker-api.herokuapp.com/all is working again. It will still be a little bit before it's fixed for v2.

@Zrna
Copy link

Zrna commented Mar 26, 2020

@ExpDev07 thank you for all the hard work!

@nguyandy
Copy link

@Zrna recoveries for https://coronavirus-tracker-api.herokuapp.com/all is working again. It will still be a little bit before it's fixed for v2.

Recoveries in Canada is not showing up properly for V1.

@web-sys1
Copy link

web-sys1 commented Apr 3, 2020

Why?

@MZDN
Copy link

MZDN commented Apr 9, 2020

Hi,
JHU is still providing recovered data:
https://github.com/CSSEGISandData/COVID-19/blob/master/csse_covid_19_data/csse_covid_19_time_series/time_series_covid19_recovered_global.csv
@ExpDev07 Could you please adjust the api? Thanks

@nkutinha
Copy link

nkutinha commented Apr 10, 2020

Thanks for this excellent API :)
Would be really cool if the recovered numbers are enabled again, at least the last recorded number instead of 0.

@itsamirrezah
Copy link

Is there any future plan to showing recovered data for /v2 ?
Thank you for your hard work.

@Sajantoor
Copy link

Will recoveries be added to v2?

@Kilo59
Copy link
Collaborator

Kilo59 commented Apr 23, 2020

@itsamirrezah @Sajantoor
Yes, no-one has gotten around to doing it though.

# locations_recovered = recovered["locations"]
# Final locations to return.
locations = []
# Go through locations.
for index, location in enumerate(locations_confirmed):
# Get the timelines.
timelines = {
"confirmed": locations_confirmed[index]["history"],
"deaths": locations_deaths[index]["history"],
# 'recovered' : locations_recovered[index]['history'],

The issue is the recovered data set doesn't match the other data sets 1-to-1, so they need to be merged.
https://github.com/CSSEGISandData/COVID-19/tree/master/csse_covid_19_data/csse_covid_19_time_series

@Kilo59 Kilo59 added the help wanted Extra attention is needed label Apr 23, 2020
@Kilo59 Kilo59 mentioned this issue Apr 29, 2020
@udsgit
Copy link

udsgit commented May 3, 2020

Other Idea for try to fix (for the moment) the recovered cases. Add https://github.com/CSSEGISandData/COVID-19/blob/master/csse_covid_19_data/csse_covid_19_time_series/time_series_covid19_recovered_global.csv to other route for fetch, and for example in my web application I can "merge" with any functions every country, that would great almost for my web application.

@ahmedfaaid
Copy link

Will the recovery stats ever be added in the API?

@Kilo59
Copy link
Collaborator

Kilo59 commented May 17, 2020

@ahmedfaaid That is the plan but no-one has gotten around to implementing it yet. See the rest of the thread.

I'm currently working on a major redesign to simplify the codebase (hopefully making it more friendly to new contributors).
We would happily accept a pull request to deal with the JHU recovered vs confirmed/deaths data mismatch.

@ahmedfaaid
Copy link

@Kilo59 Okay that sounds good. Hopefully someone can help implement soon. I would have contributed if I was a Python dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested source: jhu
Projects
None yet
Development

Successfully merging a pull request may close this issue.