-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
healthcheck: Loopback IP Parsing #1199
Comments
I think this would work if |
I see a backslash at the end of the label from |
I don't remember if it was the reason I have used
|
Sorry, looking at the documentation string, this is something expected. Labels need to be unique, so that's why there is a |
hmm - maybe a better approach was to support regex as an arg so this wouldn't be confusing. I mean now you can't use it unless you change the names completely. |
It would break existing setups and just adding a new option means more code to support, more bugs and more people confused. In years, this is the first time this issue is reported. If we were to start over, we would use "label + number" like the example, but now, who knows how people did use this feature. |
** Bug Report **
Describe the bug
When having two ips with labels like
labelname
andlabelname-something
, specifying--label labelname
would pick bothlabelname
andlabelname-something
.Expected behavior
Only the desired label be chosen.
Additional context
It must be probably because of the
startswith
func here (https://github.com/Exa-Networks/exabgp/blob/main/src/exabgp/application/healthcheck.py#L221)The text was updated successfully, but these errors were encountered: