Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orphans appear to cause git merge-base to fail #3

Open
ErichDonGubler opened this issue Jun 2, 2023 · 1 comment
Open

Orphans appear to cause git merge-base to fail #3

ErichDonGubler opened this issue Jun 2, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ErichDonGubler
Copy link
Owner

No description provided.

@ErichDonGubler ErichDonGubler added the bug Something isn't working label Jun 16, 2023
@ErichDonGubler
Copy link
Owner Author

ErichDonGubler commented Jul 24, 2023 •
edited
Loading

It's possible we might be able to make this work with a few things combined:

  1. Switching to use --boundary instead of using the ^@ suffix in ^$MERGE_BASE@^.
  2. Fixing the then-broken case where only a single commit is specified to be shown, like if main is checked out git-glimpse stack is run.

I think before we comfortably do the above, we will need to add tests (see #19).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ErichDonGubler