Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-global install doesn't seem to work #18

Open
manthey opened this issue Oct 17, 2022 · 1 comment
Open

Non-global install doesn't seem to work #18

manthey opened this issue Oct 17, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@manthey
Copy link

manthey commented Oct 17, 2022

Using node 16.14.2 and npm 8.10.0, installing via npm install @enterthenamehere/esdoc @enterthenamehere/esdoc-standard-plugin, I get the following error:

/tmp/a/node_modules/@enterthenamehere/esdoc/out/ESDoc.js:118
    this.PluginManager.setGlobalConfig(this._getGlobalConfig(config));
                       ^

TypeError: Cannot read properties of null (reading 'setGlobalConfig')
    at Function.generate (/tmp/a/node_modules/@enterthenamehere/esdoc/out/ESDoc.js:118:24)
    at ESDocCLI.exec (/tmp/a/node_modules/@enterthenamehere/esdoc/out/ESDocCLI.js:74:22)
    at Object.<anonymous> (/tmp/a/node_modules/@enterthenamehere/esdoc/out/ESDocCLI.js:230:7)
    at Module._compile (node:internal/modules/cjs/loader:1103:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1157:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
    at node:internal/main/run_main_module:17:47

It looks like the global / local detection in

is setting isGlobalInstance to true, which then fails to require the other modules properly. If I manually hack that file to set isGlobalInstance to false, it works.

For what it is worth, I tried it with an older node/npm and got the same issue.

@EnterTheNameHere
Copy link
Owner

Thank you for reporting! I'll look into it.

@EnterTheNameHere EnterTheNameHere self-assigned this Oct 17, 2022
@EnterTheNameHere EnterTheNameHere added the bug Something isn't working label Oct 17, 2022
manthey added a commit to girder/girder that referenced this issue Oct 3, 2023
manthey added a commit to girder/girder that referenced this issue Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants