New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix line SVG dotted animation in strict mode #174

Open

Reflejo wants to merge 1 commit into Eliav2:master from Reflejo:fz/fix-animated-line

Reflejo commented Mar 12, 2023 •

edited

Loading

This was broken in strict mode. I honestly am not sure how this worked before since lineDrawAnimRef (https://github.com/Eliav2/react-xarrows/blob/master/src/Xarrow/Xarrow.tsx#L175) will always be undefined (if no drawing animation happens), therefore handleDrawAmimEnd is never called.

Fixes #151


          Fix line animation

bb45e6d

This was broken in strict mode.

Reflejo changed the title ~~Fix line animation~~ Fix line SVG animation in strict mode

Reflejo changed the title ~~Fix line SVG animation in strict mode~~ Fix line SVG dotted animation in strict mode

Reflejo force-pushed the fz/fix-animated-line branch from 1409cdd to bb45e6d Compare

June 30, 2023 04:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet