Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If id is removed from dom or not available Xarrow must give error #135

Open
vikasacharya16 opened this issue Apr 14, 2022 · 4 comments
Open

Comments

@vikasacharya16
Copy link

<YourComponent id={'comp1'}/>
<YourComponent id={'comp2'}/>
<Xarrow start={'comp1'} end={'comp2'}/>

if comp2 is remove from dom Then I was getting like below. Instead Xarrow show give an error or something to handle this situation. Also When i put comp2 back Xarrow is not rerendering. Kindly fix the issue

chrome-capture

@gbarkhatov
Copy link

Did you solve the issue @vikasacharya16 ?

@viktormarinho
Copy link

Any updates on this @vikasacharya16 ?

@vikasacharya16
Copy link
Author

vikasacharya16 commented Nov 28, 2023

@gbarkhatov @viktormarinho No, I didn't solved. if the dom element start or end is removed then relation should vanish. if its changed it should rerender. give me some hints on how to achieve this.

@MagnusPladsen
Copy link

I have same issue here.

If the target is removed from the DOM the arrow bugs out.

Since the arrows is a generated svg there is no possible way to remove it in the code. (as i know of)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants