Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort pylenium.json #296

Open
ElSnoMan opened this issue Nov 8, 2022 Discussed in #280 · 1 comment
Open

Sort pylenium.json #296

ElSnoMan opened this issue Nov 8, 2022 Discussed in #280 · 1 comment
Labels
beginner Small - requires some line changes and a test or two chore Miscellaneous tasks for the repo/project

Comments

@ElSnoMan
Copy link
Owner

ElSnoMan commented Nov 8, 2022

Discussed in #280

Originally posted by mwonderful-idbydna July 26, 2022
Hi! Nothing big here. I run jsonlint across all JSON files in my work and this changes the order in the pyleniujm.json. If the values are not being sorted form some reason then please do tell!

Thanks!
-Mybrid

@ElSnoMan ElSnoMan added beginner Small - requires some line changes and a test or two chore Miscellaneous tasks for the repo/project labels Nov 8, 2022
@ElSnoMan ElSnoMan changed the title Sort pylenium.json? Sort pylenium.json Nov 8, 2022
@ElSnoMan
Copy link
Owner Author

ElSnoMan commented Nov 8, 2022

@mwonderful-idbydna I'm turning this into an Issue so it can get resolved. Not sorting it wasn't anything intentional haha. When I created the JSON it was more in the order of importance -- you'll probably update values in the driver object 90+% of the time for example.

So we can sort it and see how things look, no problem 😄
In the meantime, you can have your pre-commit hooks do the sorting or ignore the file with your linter. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner Small - requires some line changes and a test or two chore Miscellaneous tasks for the repo/project
Projects
None yet
Development

No branches or pull requests

1 participant