Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement omnidirectional motion model #111

Closed
1 task done
nahueespinosa opened this issue Feb 13, 2023 · 2 comments · Fixed by #120
Closed
1 task done

Implement omnidirectional motion model #111

nahueespinosa opened this issue Feb 13, 2023 · 2 comments · Fixed by #120
Labels
cpp Related to C++ code enhancement New feature or request

Comments

@nahueespinosa
Copy link
Member

nahueespinosa commented Feb 13, 2023

Description

Now that #56 is done, we can aim to implement the omnidirecional model as an alternative motion model in beluga.

Definition of done

  • An omnidirectional motion model class with tests added to beluga.

Additional considerations

The motion model used in the particle filter is fixed at compile time. We have not yet defined a way to support sensor model selection at runtime, so adding the parameter to select between different models is outside the scope of this ticket. Although it would be nice to test the new model locally with the ROS2 node, even if those changes won't be pushed yet.

@nahueespinosa nahueespinosa added enhancement New feature or request cpp Related to C++ code labels Feb 13, 2023
@olmerg
Copy link
Collaborator

olmerg commented Feb 16, 2023

I make the class OmniDriveMotion and it is working the unitary tests and beluga_example(changing diff_drive plugin of flatland). But I do not understand how to switch in amcl_node between the two motion models, I will wait #118 and #119 to have a clear route.

omnidrive2

@ivanpauno
Copy link
Collaborator

I make the class OmniDriveMotion and it is working the unitary tests and beluga_example(changing diff_drive plugin of flatland). But I do not understand how to switch in amcl_node between the two motion models, I will wait #118 and #119 to have a clear route.

I think you could create a PR with what you have, and the PR adding how to choose between one or the other in the amcl node can be a separate one.

nahueespinosa pushed a commit that referenced this issue Mar 6, 2023
Closes #111.

This patch adds an omnidirectional drive motion model with its corresponding
tests. The implementation is based on the model described in #56.

Signed-off-by: Olmer Garcia-Bedoya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Related to C++ code enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants