Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixer without source, kills following mixes (no more output) #5793

Open
1 task done
mama99de opened this issue Jan 16, 2025 · 5 comments · May be fixed by #5798
Open
1 task done

Mixer without source, kills following mixes (no more output) #5793

mama99de opened this issue Jan 16, 2025 · 5 comments · May be fixed by #5798
Labels
bug 🪲 Something isn't working

Comments

@mama99de
Copy link

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

If for example an mixer without Source is set up, all following mixes are not working any more
Image
In this case, starting from mix 6 no more output

Mixers without Source, can only be Set up using Companion, on the TX itself it is not possible to setup a mix without source

Expected Behavior

Mixer without source should not kill all following mixes

Steps To Reproduce

Just set up any mixer without source in Companion like here:
Image
and mix starting from CH6 will not work any longer

Can be produced using the FRSKY Xlite or on my RM Pocket, as well as in simulation in Companion,

Version

2.10.5

Transmitter

FrSky X-Lite / S / Pro

Operating System (OS)

Windows

OS Version

Win 10

Anything else?

Mixers without Source, can only be Set up using Companion

@mama99de mama99de added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Jan 16, 2025
@elecpower
Copy link
Collaborator

elecpower commented Jan 16, 2025

Empty source is permitted in Companion to allow conversion between incompatible radios without dropping the whole mixer line. The mixer line should either be deleted or a valid source added for compatibility with radio firmware.

@elecpower
Copy link
Collaborator

Suggested change to Companion is for mixer lines without source to be dropped on writing to yaml files since the user has had an opportunity to fix after conversion but failed to do so.

If they want the dropped mixer lines back they only need to reconvert and add a valid source before writing.

@elecpower elecpower removed the triage Bug report awaiting review / sorting label Jan 16, 2025
@pfeerick
Copy link
Member

pfeerick commented Jan 16, 2025 via email

@philmoz
Copy link
Collaborator

philmoz commented Jan 16, 2025

Suggested change to Companion is for mixer lines without source to be dropped on writing to yaml files since the user has had an opportunity to fix after conversion but failed to do so.

Maybe add a warning that there are invalid mixer lines that will be deleted and let the user cancel the operation.

@elecpower
Copy link
Collaborator

I suspect inputs suffer from the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants