Fix linking to config pages for disabled scrapers

Also makes navigating to these a 404 instead of erroring out. See 84ee8dc#comments
Earlopain · Oct 13, 2023 · 753ad61 · 753ad61
1 parent 7c6d7c8
commit 753ad61
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/app/controllers/config_controller.rb b/app/controllers/config_controller.rb
@@ -6,6 +6,7 @@ def index
 
   def show
     @definition = Sites.from_enum(params[:id])
+    raise ActiveRecord::RecordNotFound unless @definition
   end
 
   def modify

diff --git a/app/views/stats/index.html.erb b/app/views/stats/index.html.erb
@@ -16,7 +16,7 @@
       <% entry = @counts[definition.site_type] || {} %>
       <% next unless definition.scraper? || entry["file_count"] %>
       <tr>
-        <td><%= link_to_if(definition.site_type != "manual", definition.display_name, config_path(definition.site_type)) %></td>
+        <td><%= link_to_if(definition.scraper?, definition.display_name, config_path(definition.site_type)) %></td>
         <td><%= link_to(entry["artist_count"] || 0, artists_path(search: { site_type: definition.site_type })) %></td>
         <td><%= link_to(entry["url_count"] || 0, artist_urls_path(search: { site_type: definition.site_type }))  %></td>
         <td><%= link_to(entry["submission_count"] || 0, submission_files_path(search: { site_type: definition.site_type }))  %></td>