Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move executor field from Algorithm to PopulationEvaluator #90

Open
itaitzruia4 opened this issue Jul 5, 2023 · 0 comments
Open

Move executor field from Algorithm to PopulationEvaluator #90

itaitzruia4 opened this issue Jul 5, 2023 · 0 comments

Comments

@itaitzruia4
Copy link
Collaborator

Currently, the algorithm receives executor and max_workers fields in its constructor, initializes the Executor object, and passes it to PopulationEvaluator, but only the PopulationEvaluator activates it.
The only reason that it is in Algorithm, is to be able to call executor.shutdown at the end of the run.

I suggest moving this field entirely to PopulationEvaluator and adding a termination method to the evaluator, which will be called from the algorithm at the end of the run.

This issue will probably be addressed along with #63.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant