Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support application icon #91

Open
puce77 opened this issue Jul 26, 2015 · 2 comments
Open

Support application icon #91

puce77 opened this issue Jul 26, 2015 · 2 comments
Milestone

Comments

@puce77
Copy link
Member

puce77 commented Jul 26, 2015

Support setting the application icon declaratively.

@puce77
Copy link
Member Author

puce77 commented Jul 26, 2015

Should this be implemented as a custom extension point with a custom annotation? Or as part of the Maven plugin? Or do we have to wait for this until we have proper packaging support (native, Java Web Start,...) as those will use icons as well?

@mainrs
Copy link

mainrs commented Mar 10, 2016

Personally I would make it a extension point for the UI. My main argument would be that the running application might need to provide icons for the window and the dock (on OS X). That can be easily covered by an extension point. The packaging of the application is another "separate" issue. The icons that are used for the packaging are independent from the scene icon (not as a resource but as a programming aspect). One has to be defined by code and the other by the packaging tool. That is my small opinion on it :)

@puce77 puce77 added this to the 0.10 milestone Dec 27, 2016
@puce77 puce77 modified the milestones: 0.11, 0.10 Mar 24, 2017
@puce77 puce77 modified the milestones: 0.12, 0.11 Aug 2, 2017
@puce77 puce77 modified the milestones: 0.12, 0.15 Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants