Prevent SRS being created multiple times for a kanji #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
I was able to pinpoint how #5 happens. Steps to reproduce:
Was able to fix this by reapplying the filter when a kanji is selected from the list.
I rebase this branch onto your master so you can choose to merge it before #24 since this is a more simple change. Whichever one you merge last might require a rebase
Update: Added another commit to also fix the issue when navigating from the vocab list. Did this by adding an instance of KanjiDao the NavigationActor singleton can use to refresh a kanji when navigating to it.