Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementations of IDisposable should check private disposed field in public/internal/protected methods #41

Open
jimmyheaddon opened this issue Sep 16, 2015 · 0 comments

Comments

@jimmyheaddon
Copy link

Linked in dotnet/roslyn-analyzers#293.

Essentially if a class correctly implements the IDisposable pattern, then public/internal/protected methods should throw ObjectDisposedException(this.GetType().FullName) as per the majority of .NET framework classes (e.g. Socket).

if (this.disposed)
{
    throw new ObjectDisposedException(this.GetType().FullName);
}

Optionally an XML comment should be declared to reflect this:

/// <exception cref="ObjectDisposedException">Thrown if this instance of <see cref="ClassName" /> has been disposed.</exception>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant