-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo with dependency to translation files in application/decorator #910
Comments
Hi @amakarudze, I'm back at it, can I take this one, maybe? |
@anaschwendler yes, please feel free 👍 |
@marksweb I'll actually open another PR first to fix another issue: should I open an issue first? PS: I was able to run via |
@anaschwendler Ok, so Portuguese Brazilian does get confusing. The language code is pt-br abut the locale name is pt_BR You can see them both here; https://docs.djangoproject.com/en/5.0/topics/i18n/#term-locale-name |
@marksweb, I see! PS: Also, I would like to contribute more, so if we can connect to align on some issues I could tackle I'd love to, thanks! |
@anaschwendler That's great. I think there's various things that could be looked at. Sentry raises issues as it sees them. Feel free to go over the issues and work on any you like the look of. I've got a branch where I've upgraded django. Getting another person to test that might be beneficial. The branch for that is here; https://github.com/marksweb/djangogirls/tree/feat/django4 |
Thank you! You should see me more often around then, I'll make sure to ask/raise questions before grabbing. |
Hi there!
Just had a look at the missing translations at POEditor and saw this typo: https://github.com/DjangoGirls/djangogirls/blob/2b2fc151354906ac116dd8cd9a9f4f412dee26af/applications/decorators.py#L21C41-L21C41
It should be "use", not "user". There is a dependency to all translations files, so we'd have to run
makemessages
again.Best
Ronny
The text was updated successfully, but these errors were encountered: