Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.28.0 #1629

Merged
merged 118 commits into from
Aug 3, 2024
Merged

v1.28.0 #1629

merged 118 commits into from
Aug 3, 2024

Conversation

granny
Copy link
Member

@granny granny commented Jan 18, 2024 •
edited by Dinty1
Loading

Blocked by #1708
Blocked by #1717
Blocked by #1466
Blocked by #1280

Wait a few days before release.

@granny granny linked an issue Jan 18, 2024 that may be closed by this pull request
Advancements are named after their file name not their title #1601
Closed
2 tasks
Scarsz and others added 17 commits March 9, 2024 03:11
@Scarsz
Load accounts from AOF backend before renaming file during JDBC import
08e99e9
@granny
change check for folia
2e37767
@granny
- use NMS for doesAnnounceToChat detection
9d71fe1 
- reorganize NMS
- throw debugs everywhere

closes #1651
@granny
bump adventure version
6a9706e
@granny
skip update checker if comparing against a local hash
507ba5f
@granny
ignore channel id's in Channels that are empty quotes
5736182
@granny
fix NPE when getting text channel
f607d9b
@granny
[ci-skip] remove static imports
95a86b9
@granny
fix formatting issue with reply message
43e00e3
@granny
vankka nitpick
c9b1965
@J-295
Use overlay in AvatarURL option (#1641)
2e4eff9
@granny
switch to using crafthead.net in offline mode detection
3c98388
@YueMiyuki
Implant web proxy support (#1556)
338f384
@SamLam140330
Improve Chinese translation (#1647)
8cbb6e9
@thewilloftheshadow
Add extra debug information (#1645)
41df62f
@J-295
Reorder roles in config (#1636)
a26cc43
@RemixedX
Norwegian translation added (#1602)
12b4ada
@granny granny linked an issue Mar 17, 2024 that may be closed by this pull request
disabled the achievement but still errors #1650
Closed
3 tasks
@Dinty1 Dinty1 linked an issue Mar 29, 2024 that may be closed by this pull request
Apply filter to attachments #1404
Closed
1 task
@Vankka Vankka marked this pull request as draft July 6, 2024 12:51
granny and others added 13 commits July 7, 2024 21:01
@granny
strip all legacy symbols from placeholderapi placeholders, closes #1720
edfedc2
@granny
don't replace placeholders for console channel prefix/suffix if they …
b1257f0 
…are empty values
@granny
bump jdaappender version, closes #1466
775b727
@granny
[ci skip] update comment on personal maven repo
8b54422
@PadowYT2
Add support for competing and custom bot statuses (#1691)
388faf7
@granny
use FileUtils.moveFile instead of File.renameTo
1fb7403
@granny
delete dest file before moving tmp file to dest, hopefully closes #1717
c76663e
@granny
[ci skip] upload adventure dependency to scarsz' nexus
af6196d
@AwesomeBFM
add PAPI placeholders for filtered top Role (#1680)
93867d7
@granny
properly remove unlinked accounts if the player's UUID starts with a …
59a6023 
…digit

Specifies 17 as the lowest amount of digits that a discord id can have.
@granny
add a bunch of debug logs throughout aof link manager
991e2e9
@J-295
Revert faulty Norwegian translation (#1723)
9c6c42b
@Dinty1
Use snapshot version of JDAAppender
b0cceb7
@Dinty1 Dinty1 marked this pull request as ready for review July 31, 2024 08:44
@Dinty1 Dinty1 requested a review from a team July 31, 2024 08:56
Vankka
Vankka requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@Vankka Vankka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build in unreproducable + a few other in-line comments

build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Show resolved Hide resolved
src/main/java/github/scarsz/discordsrv/api/commands/PluginSlashCommand.java Show resolved Hide resolved
src/main/java/github/scarsz/discordsrv/api/commands/PluginSlashCommand.java Show resolved Hide resolved
src/main/java/github/scarsz/discordsrv/api/commands/CommandRegistrationError.java Show resolved Hide resolved
@Dinty1 Dinty1 requested a review from Scarsz August 1, 2024 22:08
@Scarsz Scarsz merged commit 49b83f3 into master Aug 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scarsz Scarsz Scarsz approved these changes

@Vankka Vankka Vankka approved these changes

@Dinty1 Dinty1 Dinty1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone