A few cleanups I had on a branch #10701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlaminSarge
reviewed
Aug 30, 2024
There was a problem hiding this comment.
If one doesn't already exist, may just be better to name this loadout-utils and stick any other loadout-related utils in it instead of keeping it scoped to items. Seems like the methods in here are kinda already not necessarily item-related anyways.
There was a problem hiding this comment.
Yeah it's all pretty messy, especially with loadouts and loadout-drawer folders. These are definitely just random helpers that could be somewhere better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reorderfunction