Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use first sorted item in Compare view as 'firstCompareItem' rather than first unsorted item #10693

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

FlaminSarge
Copy link
Contributor

@FlaminSarge FlaminSarge commented Aug 21, 2024

Also confirmed that if the sorting is changed it updates properly (when initialItem is no longer in the list).

Initial state:
Screenshot 2024-08-21 at 5 49 55 AM

Previous behavior after removing first item:
Screenshot 2024-08-21 at 5 50 14 AM

Updated behavior after removing first item:
Screenshot 2024-08-21 at 5 49 43 AM

@bhollis
Copy link
Contributor

bhollis commented Aug 21, 2024

If the initial item is missing, we probably shouldn't show the first button at all - there's no longer a reasonable "comparison exemplar" for the session, and choosing any of the remaining items is as good as any.

@FlaminSarge
Copy link
Contributor Author

If the initial item is missing, we probably shouldn't show the first button at all - there's no longer a reasonable "comparison exemplar" for the session, and choosing any of the remaining items is as good as any.

I'm not so sure on that, I've definitely had a use case where I removed the initial item to check something and then 'reset' the compare window using the first button. I feel that if a user starts a compare session they should be able to get back to initial session state without having to find the item in vault to start Compare again, and the first button handles that pretty well.

@FlaminSarge FlaminSarge merged commit 288d2c5 into DestinyItemManager:master Aug 26, 2024
6 checks passed
@FlaminSarge FlaminSarge deleted the compare-example branch August 26, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants